fix: minor types fix

4lessandrodev · 4lessandrodev · commit 7a1d343538f7 · 2024-04-28T16:29:52.000-03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,9 +10,9 @@ All notable changes to this project will be documented in this file.
 
 ### [3.9.0] - 2024-04-28
 
-### Update
+### Update (Break Change)
 
-- Update core
+- Update core to v1.23.0
 - check [Core Changelog](https://github.com/4lessandrodev/rich-domain/blob/main/CHANGELOG.md)
 
 ---
diff --git a/lib/utils/birthday.value-object.ts b/lib/utils/birthday.value-object.ts
@@ -8,11 +8,10 @@ interface Prop {
 export class BirthdayValueObject extends ValueObject<Prop> {
 	private readonly ONE_YEAR: number = 31536000902;
 	protected static readonly MAX_HUMAN_AGE: number = 121;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = `Invalid age for a human. Must has less than ${BirthdayValueObject.MAX_HUMAN_AGE} years old and birth not in future`;
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: BirthdayValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	/**
diff --git a/lib/utils/cnpj.value-object.ts b/lib/utils/cnpj.value-object.ts
@@ -13,11 +13,10 @@ interface Prop {
 
 export class CNPJValueObject extends ValueObject<Prop> {
 	protected static readonly REGEX = regexCnpj;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid value for cnpj';
 
 	private constructor(props: Prop) {
-		super(props, { disableSetters: CNPJValueObject.DISABLE_SETTER });
+		super(props);
 		this.removeSpecialChars();
 	}
 
diff --git a/lib/utils/cpf.value-object.ts b/lib/utils/cpf.value-object.ts
@@ -11,11 +11,10 @@ interface Prop {
 
 export class CPFValueObject extends ValueObject<Prop> {
 	protected static readonly REGEX = regexCpf;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid value for cpf';
 
 	private constructor(props: Prop) {
-		super(props, { disableSetters: CPFValueObject.DISABLE_SETTER });
+		super(props);
 		this.removeSpecialChars();
 	}
 
diff --git a/lib/utils/currency.value-object.ts b/lib/utils/currency.value-object.ts
@@ -56,11 +56,10 @@ interface Prop {
  */
 class CurrencyValueObject extends ValueObject<Prop> {
 	private cents: number;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = `Value is not a safe number, must be between ${minSafeValue} and ${maxSafeValue}`;
 
 	private constructor(props: Prop) {
-		super(props, { disableSetters: CurrencyValueObject.DISABLE_SETTER });
+		super(props);
 		this.cents = convertValueToCent(props.value);
 	}
 
diff --git a/lib/utils/custom-number.value-object.ts b/lib/utils/custom-number.value-object.ts
@@ -21,14 +21,11 @@ export class CustomNumberValueObject extends ValueObject<Prop> {
 	};
 	protected static readonly MAX: number = Number.MAX_SAFE_INTEGER;
 	protected static readonly MIN: number = Number.MIN_SAFE_INTEGER;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string =
 		'Invalid value for a custom number';
 
 	private constructor(props: Prop) {
-		super(props, {
-			disableSetters: CustomNumberValueObject.DISABLE_SETTER,
-		});
+		super(props);
 	}
 
 	/**
diff --git a/lib/utils/custom-string.value-object.ts b/lib/utils/custom-string.value-object.ts
@@ -21,14 +21,11 @@ export class CustomStringValueObject extends ValueObject<Prop> {
 	};
 	protected static readonly MAX_LENGTH: number = 255;
 	protected static readonly MIN_LENGTH: number = 1;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string =
 		'Invalid value for a custom string';
 
 	private constructor(props: Prop) {
-		super(props, {
-			disableSetters: CustomStringValueObject.DISABLE_SETTER,
-		});
+		super(props);
 	}
 
 	/**
diff --git a/lib/utils/date-value-object.ts b/lib/utils/date-value-object.ts
@@ -41,10 +41,9 @@ export class DateValueObject extends ValueObject<Prop> {
 	private readonly ONE_MONTH: number = 2678400000;
 	private readonly ONE_WEEK: number = 604800000;
 	private readonly ONE_YEAR: number = 31622400000;
-	protected static readonly DISABLE_SETTER: boolean = true;
 
 	private constructor(props: Prop) {
-		super(props, { disableSetters: DateValueObject.DISABLE_SETTER });
+		super(props);
 	}
 
 	/**
diff --git a/lib/utils/dimension.value-object.ts b/lib/utils/dimension.value-object.ts
@@ -14,11 +14,10 @@ interface Props {
 }
 
 export class DimensionValueObject extends ValueObject<DimensionValueObjectProps> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid unit for Dimension';
 
 	private constructor(props: DimensionValueObjectProps) {
-		super(props, { disableSetters: DimensionValueObject.DISABLE_SETTER });
+		super(props);
 	}
 
 	get dimension(): CustomNumberValueObject {
diff --git a/lib/utils/email.value-object.ts b/lib/utils/email.value-object.ts
@@ -7,13 +7,12 @@ interface Prop {
 }
 
 export class EmailValueObject extends ValueObject<Prop> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly BLOCKED_DOMAINS: Array<string> = [];
 	protected static readonly VALID_DOMAINS: Array<string> = [];
 	protected static readonly MESSAGE: string = 'Invalid email';
 
 	private constructor(props: Prop) {
-		super(props, { disableSetters: EmailValueObject.DISABLE_SETTER });
+		super(props);
 	}
 
 	value(): string {
diff --git a/lib/utils/hex-color.value-object.ts b/lib/utils/hex-color.value-object.ts
@@ -9,11 +9,10 @@ interface Prop {
 }
 
 class HEXColorValueObject extends ValueObject<Prop> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly REGEX = regexHash;
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: HEXColorValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	value(): string {
diff --git a/lib/utils/home-phone.value-object.ts b/lib/utils/home-phone.value-object.ts
@@ -13,11 +13,10 @@ interface Prop {
  */
 class HomePhoneValueObject extends ValueObject<Prop> {
 	protected static readonly REGEX = regexHash;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid Home Phone Number';
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: HomePhoneValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	validation(value: string): boolean {
diff --git a/lib/utils/mobile-phone.value-object.ts b/lib/utils/mobile-phone.value-object.ts
@@ -14,11 +14,10 @@ interface Prop {
  */
 class MobilePhoneValueObject extends ValueObject<Prop> {
 	protected static readonly REGEX = regexHash;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid Mobile Phone Number';
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: MobilePhoneValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	/**
diff --git a/lib/utils/order-status.value-object.ts b/lib/utils/order-status.value-object.ts
@@ -114,12 +114,11 @@ interface OrderStatusProps {
  * Seller has partially refunded the order.
  */
 class OrderStatusValueObject extends ValueObject<OrderStatusProps> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string =
 		'Invalid status value for an order';
 
 	private constructor(props: OrderStatusProps) {
-		super(props, { disableSetters: OrderStatusValueObject.DISABLE_SETTER });
+		super(props);
 	}
 
 	/**
diff --git a/lib/utils/password.value-object.ts b/lib/utils/password.value-object.ts
@@ -11,14 +11,11 @@ interface Prop {
 class PasswordValueObject extends ValueObject<Prop> {
 	protected static readonly MAX_LENGTH = 22;
 	protected static readonly MIN_LENGTH = 5;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly REGEX = regexHash;
 	protected static readonly MESSAGE: string = `Password must has min ${PasswordValueObject.MIN_LENGTH} and max ${PasswordValueObject.MAX_LENGTH} chars`;
 
 	private constructor(props: Prop) {
-		super(props, {
-			disableSetters: PasswordValueObject.DISABLE_SETTER,
-		});
+		super(props);
 	}
 
 	/**
diff --git a/lib/utils/pin.value-object.ts b/lib/utils/pin.value-object.ts
@@ -13,11 +13,10 @@ interface Prop {
  * @example ABCDEF-123456
  */
 export class PinValueObject extends ValueObject<Prop> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid value for a pin';
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: PinValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	/**
diff --git a/lib/utils/postal-code.value-object.ts b/lib/utils/postal-code.value-object.ts
@@ -7,12 +7,11 @@ interface Prop {
 }
 
 class PostalCodeValueObject extends ValueObject<Prop> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly REGEX = regexHash;
 	protected static readonly MESSAGE: string = 'Invalid postal code';
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: PostalCodeValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	/**
diff --git a/lib/utils/rgb-color.value-object.ts b/lib/utils/rgb-color.value-object.ts
@@ -11,12 +11,11 @@ interface Prop {
 
 class RGBColorValueObject extends ValueObject<Prop> {
 	protected static readonly REGEX = regexHash;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string =
 		'Invalid rgb value. It must match with pattern rgb(255, 255, 255)';
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: RGBColorValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	value(): string {
diff --git a/lib/utils/tracking-code.value-object.ts b/lib/utils/tracking-code.value-object.ts
@@ -9,14 +9,11 @@ interface OrderIdProps {
 
 class TrackingCodeValueObject extends ValueObject<OrderIdProps> {
 	protected static readonly REGEX = regexHash;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string =
 		'Invalid value for Tracking code';
 
 	private constructor(props: OrderIdProps) {
-		super(props, {
-			disableSetters: TrackingCodeValueObject.DISABLE_SETTER,
-		});
+		super(props);
 	}
 
 	/**
diff --git a/lib/utils/unit-of-measure.value-object.ts b/lib/utils/unit-of-measure.value-object.ts
@@ -26,13 +26,10 @@ interface Prop {
 }
 
 export class UnitOfMeasureValueObject extends ValueObject<Prop> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid unit of measure value';
 
 	private constructor(props: Prop) {
-		super(props, {
-			disableSetters: UnitOfMeasureValueObject.DISABLE_SETTER,
-		});
+		super(props);
 	}
 
 	value(): UnitOfMeasure {
diff --git a/lib/utils/url.value-object.ts b/lib/utils/url.value-object.ts
@@ -6,11 +6,10 @@ interface Prop {
 }
 
 class UrlValueObject extends ValueObject<Prop> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid url value';
 
 	private constructor(prop: Prop) {
-		super(prop, { disableSetters: UrlValueObject.DISABLE_SETTER });
+		super(prop);
 	}
 
 	/**
diff --git a/lib/utils/user-name.value-object.ts b/lib/utils/user-name.value-object.ts
@@ -8,11 +8,10 @@ interface Prop {
 export class UserNameValueObject extends ValueObject<Prop> {
 	protected static readonly MAX_LENGTH: number = 41;
 	protected static readonly MIN_LENGTH: number = 2;
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = `Invalid name length. Must has min ${UserNameValueObject.MIN_LENGTH} and max ${UserNameValueObject.MAX_LENGTH} chars`;
 
 	private constructor(props: Prop) {
-		super(props, { disableSetters: UserNameValueObject.DISABLE_SETTER });
+		super(props);
 		this.capitalize();
 	}
 
diff --git a/lib/utils/weight-unit.value-object.ts b/lib/utils/weight-unit.value-object.ts
@@ -26,11 +26,10 @@ interface Prop {
 }
 
 export class WeightUnitValueObject extends ValueObject<Prop> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid weight unit value';
 
 	private constructor(props: Prop) {
-		super(props, { disableSetters: WeightUnitValueObject.DISABLE_SETTER });
+		super(props);
 	}
 
 	value(): UnitOfWeight {
diff --git a/lib/utils/weight.value-object.ts b/lib/utils/weight.value-object.ts
@@ -14,11 +14,10 @@ interface Props {
 }
 
 export class WeightValueObject extends ValueObject<WeightValueObjectProps> {
-	protected static readonly DISABLE_SETTER: boolean = true;
 	protected static readonly MESSAGE: string = 'Invalid unit for weight';
 
 	private constructor(props: WeightValueObjectProps) {
-		super(props, { disableSetters: WeightValueObject.DISABLE_SETTER });
+		super(props);
 	}
 
 	/**
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "types-ddd",
-	"version": "3.9.0-beta.0",
+	"version": "3.9.0",
 	"description": "This package provide utils file and interfaces to assistant build a complex application with domain driving design",
 	"main": "dist/index.js",
 	"types": "dist/index.d.ts",
@@ -61,7 +61,7 @@
 		"bcrypt": "^5.0.1",
 		"pino": "^8.17.1",
 		"pino-pretty": "^11.0.0",
-		"rich-domain": "1.23.0-beta.0"
+		"rich-domain": "^1.23.0"
 	},
 	"devDependencies": {
 		"@microsoft/tsdoc": "^0.14.1",
diff --git a/yarn.lock b/yarn.lock
@@ -3611,10 +3611,10 @@ rfdc@^1.3.0:
   resolved "https://registry.yarnpkg.com/rfdc/-/rfdc-1.3.0.tgz#d0b7c441ab2720d05dc4cf26e01c89631d9da08b"
   integrity sha512-V2hovdzFbOi77/WajaSMXk2OLm+xNIeQdMMuB7icj7bk6zi2F8GGAxigcnDFpJHbNyNcgyJDiP+8nOrY5cZGrA==
 
-rich-domain@1.23.0-beta.0:
-  version "1.23.0-beta.0"
-  resolved "https://registry.yarnpkg.com/rich-domain/-/rich-domain-1.23.0-beta.0.tgz#8c3a79af28202fda2207757584cec96cb97da3aa"
-  integrity sha512-sLJV9SJFSv7oPA57ONNT0dvXybwc9jqIbzccF4PIJaV3SYq6k8nOcFW8jddz4GER32K+qFQgRTR5PKop6UDL6w==
+rich-domain@^1.23.0:
+  version "1.23.0"
+  resolved "https://registry.yarnpkg.com/rich-domain/-/rich-domain-1.23.0.tgz#50f527fc2a8dd660de3d08c97e990f695f70703d"
+  integrity sha512-Tfo18xWIdYNH1z8/gZA6PEj/WGucchCwfQpwdkk2QHNeYTTy4CWLWeh6ENB3b/wQFevMgRkiVpZAuPwHZWGfNg==
 
 rimraf@^3.0.0, rimraf@^3.0.2:
   version "3.0.2"

Original file line number	Diff line number	Diff line change
`@@ -14,11 +14,10 @@ interface Props {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`export class DimensionValueObject extends ValueObject<DimensionValueObjectProps> {`
`17`		`- protected static readonly DISABLE_SETTER: boolean = true;`
`18`	`17`	`protected static readonly MESSAGE: string = 'Invalid unit for Dimension';`
`19`	`18`
`20`	`19`	`private constructor(props: DimensionValueObjectProps) {`
`21`		`- super(props, { disableSetters: DimensionValueObject.DISABLE_SETTER });`
	`20`	`+ super(props);`
`22`	`21`	`}`
`23`	`22`
`24`	`23`	`get dimension(): CustomNumberValueObject {`
Original file line number	Diff line number	Diff line change
`@@ -7,13 +7,12 @@ interface Prop {`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`export class EmailValueObject extends ValueObject<Prop> {`
`10`		`- protected static readonly DISABLE_SETTER: boolean = true;`
`11`	`10`	`protected static readonly BLOCKED_DOMAINS: Array<string> = [];`
`12`	`11`	`protected static readonly VALID_DOMAINS: Array<string> = [];`
`13`	`12`	`protected static readonly MESSAGE: string = 'Invalid email';`
`14`	`13`
`15`	`14`	`private constructor(props: Prop) {`
`16`		`- super(props, { disableSetters: EmailValueObject.DISABLE_SETTER });`
	`15`	`+ super(props);`
`17`	`16`	`}`
`18`	`17`
`19`	`18`	`value(): string {`