Merge pull request #77 from ARMmbed/issue_popen

Add command execution feature with subprocess.communicate()

Author: PrzemekWirkus

mbed_lstools/lstools_base.py

@@ -576,3 +576,15 @@ def scan_html_line_for_target_id(self, line):
                     self.debug(self.scan_html_line_for_target_id.__name__, (m.groups(), result))
                 return result
         return None
+
+    @staticmethod
+    def run_cli_process(cmd, shell=True):
+        """! Runs command as a process and return stdout, stderr and ret code
+        @param cmd Command to execute
+        @return Tuple of (stdout, stderr, returncode)
+        """
+        from subprocess import Popen, PIPE
+
+        p = Popen(cmd, shell=shell, stdout=PIPE, stderr=PIPE)
+        _stdout, _stderr = p.communicate()
+        return _stdout, _stderr, p.returncode

mbed_lstools/lstools_linux_generic.py

@@ -16,7 +16,6 @@
 """
 
 import re
-import subprocess
 
 from lstools_base import MbedLsToolsBase
 
@@ -127,10 +126,8 @@ def get_dev_by_id_cmd(self, subdir):
         @return tuple(stdout lines, retcode)
         """
         cmd = 'ls -oA /dev/' + subdir + '/by-id/'
-        if self.DEBUG_FLAG:
-            self.debug(self.get_dev_by_id_cmd.__name__, cmd)
-        p = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
-        return (p.stdout.readlines(), p.wait())
+        _stdout, _, retval = self.run_cli_process(cmd)
+        return (_stdout.splitlines(), retval)
 
     def get_dev_by_id_process(self, lines, retval):
         """! Remove unnecessary lines from command line output
@@ -159,13 +156,14 @@ def get_mounts(self):
         """
         result = []
         cmd = 'mount | grep vfat'
+
         if self.DEBUG_FLAG:
             self.debug(self.get_mounts.__name__, cmd)
 
-        p = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
-        retval = p.wait()
+        _stdout, _, retval = self.run_cli_process(cmd)
+
         if not retval:
-            for line in p.stdout.readlines():
+            for line in _stdout.splitlines():
                 line = line.rstrip()
                 result.append(line)
                 if self.DEBUG_FLAG: