Skip to content

Conversation

@AbdulGoodLooks
Copy link

@AbdulGoodLooks AbdulGoodLooks commented Nov 11, 2025

Workaround to attempt to prevent creating rules that break aw-server like this https://forum.activitywatch.net/t/invalid-syntax-for-value-to-assign-out-of-nowhere/4627/3


Important

Update validateRegex to flag semicolons in regex as invalid to prevent server errors.

  • Behavior:
    • Update validateRegex in validate.ts to return false if regex contains semicolons, preventing server errors.
  • Validation:
    • Semicolons in regex patterns are now flagged as invalid to avoid breaking aw-server.

This description was created by Ellipsis for 93f4484. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 93f4484 in 1 minute and 31 seconds. Click for details.
  • Reviewed 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/util/validate.ts:6
  • Draft comment:
    Document the rationale further: consider adding the forum post URL in the comment so future maintainers understand why semicolons break aw-server.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to document the rationale further by adding a URL to a forum post. This is a request for additional documentation, which is not allowed according to the rules. The comment does not provide a specific code suggestion or ask for a test to be written, so it should be removed.

Workflow ID: wflow_E2xAh4bMlQ1LhDNM

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 26.29%. Comparing base (c766e86) to head (3d1e04f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/util/validate.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
- Coverage   26.30%   26.29%   -0.02%     
==========================================
  Files          29       29              
  Lines        1684     1685       +1     
  Branches      301      302       +1     
==========================================
  Hits          443      443              
+ Misses       1219     1180      -39     
- Partials       22       62      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant