Skip to content

Commit 8a1d630

Browse files
cleanup
1 parent 3c6debd commit 8a1d630

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

things3/things3_api.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
class Things3API():
2828
"""API Wrapper for the simple read-only API for Things 3."""
2929

30-
HOST = 'localhost'
31-
PORT = 15000
3230
PATH = getcwd() + '/resources/'
3331
things3 = None
3432
test_mode = "task"
33+
host = 'localhost'
34+
port = 15000
3535

3636
def on_get(self, url):
3737
"""Handles other GET requests"""
@@ -100,7 +100,12 @@ def api_filter_reset(self):
100100
self.things3.filter = ""
101101
return Response(status=200)
102102

103-
def __init__(self, database=None):
103+
def __init__(self, database=None, host=None, port=None):
104+
cfg = Things3.get_from_config(Things3.config, host, 'KANBANVIEW_HOST')
105+
self.host = cfg if cfg else self.host
106+
cfg = Things3.get_from_config(Things3.config, port, 'KANBANVIEW_PORT')
107+
self.port = cfg if cfg else self.port
108+
104109
self.things3 = Things3(database=database)
105110
self.flask = Flask(__name__)
106111
self.flask.add_url_rule('/api/<command>', view_func=self.api)
@@ -114,11 +119,11 @@ def __init__(self, database=None):
114119

115120
def main(self):
116121
""""Main function."""
117-
print(f"Serving at http://{self.HOST}:{self.PORT} ...")
122+
print(f"Serving at http://{self.host}:{self.port} ...")
118123

119124
try:
120125
self.flask_context = make_server(
121-
self.HOST, self.PORT, self.flask, True)
126+
self.host, self.port, self.flask, True)
122127
self.flask_context.serve_forever()
123128
except KeyboardInterrupt:
124129
print("Shutting down...")

things3/things3_app.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def sigterm_handler(self, _signo, _stack_frame):
5050
def main(self):
5151
"""Run the app."""
5252
# kill possible zombie processes; can't use psutil in py2app context
53-
system('lsof -nti:' + str(things3_api.Things3API.PORT) +
53+
system('lsof -nti:' + str(things3_api.Things3API.port) +
5454
' | xargs kill -9')
5555

5656
# Make sure the server shuts down
@@ -60,8 +60,8 @@ def main(self):
6060

6161
webview.create_window(
6262
title='KanbanView',
63-
url=f'http://{things3_api.Things3API.HOST}:' +
64-
f'{things3_api.Things3API.PORT}/{self.FILE}',
63+
url=f'http://{things3_api.Things3API.host}:' +
64+
f'{things3_api.Things3API.port}/{self.FILE}',
6565
width=1280, height=650,
6666
min_size=(1280, 650),
6767
frameless=True)

0 commit comments

Comments
 (0)