Repository navigation
getCCDBTimeMachineTimestamp.py: publish the NotAfter estimate to CCDB - #2509
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
c3c0e1f to
7085882
Compare
sawenzel
left a comment
There was a problem hiding this comment.
Thanks, this is a good step towards https://its.cern.ch/jira/browse/O2-6543. Apart from the small inline points, I would merge it as is, since nothing uses the script in production yet.
One question for the next iteration: the object is keyed by Period and Pass, but the value is estimated from a single run. Do we know that all runs of a pass are reconstructed close enough in time for one value to fit them all? If not, we could key by run, or have each job compare the shared value with its own estimate and warn when a reference object like TPC/Calib/CorrectionMapV2 resolves differently.
Next steps: publish and consume the object from o2dpg_sim_workflow_anchored.py, following MCProdInfo, with ALIEN_JDL_CCDB_CONDITION_NOT_AFTER kept as the override. The certificate and upload helpers could then move to a common module, as your FIXME already suggests.
|
@sawenzel thanks for the review. I pushed two more commits which should address your suggestions. |
This allows to store the estimated NotAfter timestamp of a period and pass in
CCDB as a
CCDBTimeMachineTSobject, so that the estimate is done once perpass and not in every job.
Pass, and only estimates from the catalogue when none is found.
--publish-to-ccdbuploads the estimate,--force-overwritereplaces anexisting object and
--skip-ccdb-queryskips the lookup.Nothing uses the script in production yet.
https://its.cern.ch/jira/browse/O2-6543