Repository navigation
Commit 2f14b38
refactor(core): fix forward refs and modernize instrument annotations
Why:
* the quoted "CaptchaParams" forward references in both instruments
resolved to no import, so static analysis flagged them as undefined
* Optional[...] and quoted annotations predate lazy annotation support
What:
* add a TYPE_CHECKING-guarded CaptchaParams import to break the
annotation-only import cycle with base.py
* add from __future__ import annotations and switch the single
Optional[dict] parameter to dict | None (lazy, so python 3.8+ stays
supported)
* unquote the CaptchaParams parameter annotation
no runtime behavior change: the guard never executes and annotations
are never evaluated; the full mocked suite passes identically
Changes:
* src/python3_capsolver/core/sio_captcha_instrument.py: typing hygiene
* src/python3_capsolver/core/aio_captcha_instrument.py: typing hygiene
Stats:
* 2 files changed
* +10/-4 lines
Co-authored-by: Claude <noreply@anthropic.com>1 parent bb594d9 commit 2f14b38
2 files changed
Lines changed: 16 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | | - | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
14 | 19 | | |
15 | 20 | | |
16 | 21 | | |
| |||
19 | 24 | | |
20 | 25 | | |
21 | 26 | | |
22 | | - | |
| 27 | + | |
23 | 28 | | |
24 | 29 | | |
25 | 30 | | |
| |||
99 | 104 | | |
100 | 105 | | |
101 | 106 | | |
102 | | - | |
| 107 | + | |
103 | 108 | | |
104 | 109 | | |
105 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
1 | 3 | | |
2 | 4 | | |
3 | | - | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
15 | 20 | | |
16 | 21 | | |
17 | 22 | | |
| |||
20 | 25 | | |
21 | 26 | | |
22 | 27 | | |
23 | | - | |
| 28 | + | |
24 | 29 | | |
25 | 30 | | |
26 | 31 | | |
| |||
106 | 111 | | |
107 | 112 | | |
108 | 113 | | |
109 | | - | |
| 114 | + | |
110 | 115 | | |
111 | 116 | | |
112 | 117 | | |
| |||
0 commit comments