-
-
Notifications
You must be signed in to change notification settings - Fork 84
Add publicly viewable CI #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
You can see a run of this here:
I added Forgejo Actions mostly due to the argument that relying on GitHub Actions is bad. (I do agree, but it is free compute that now also supports arm64) |
|
If you update to diff --git a/wpull/document/htmlparse/html5lib_.py b/wpull/document/htmlparse/html5lib_.py
index 6f24743..ba2b746 100644
--- a/wpull/document/htmlparse/html5lib_.py
+++ b/wpull/document/htmlparse/html5lib_.py
@@ -1,8 +1,8 @@
'''Parsing using html5lib python.'''
import html5lib.constants
-import html5lib.tokenizer
import io
import os.path
+from html5lib._tokenizer import HTMLTokenizer
from wpull.document.htmlparse.base import BaseParser
from wpull.document.htmlparse.element import Comment, Doctype, Element
@@ -24,7 +24,7 @@ class HTMLParser(BaseParser):
return ValueError
def parse(self, file, encoding=None):
- tokenizer = html5lib.tokenizer.HTMLTokenizer(
+ tokenizer = HTMLTokenizer(
file, encoding=encoding,
useChardet=False if encoding else True,
parseMeta=False if encoding else True,
@@ -97,7 +97,7 @@ if __name__ == '__main__':
'testing', 'samples', 'xkcd_1.html'
)
with open(path, 'rb') as in_file:
- tokenizer = html5lib.tokenizer.HTMLTokenizer(in_file)
+ tokenizer = HTMLTokenizer(in_file)
for token in tokenizer:
print(token)Actually anything before html5lib/html5lib-python@c4dd677 would work without this patch, but this change made the tokenizer class private. |
This PR ports the existing Drone CI commands to GitHub Actions and Forgejo Actions.
It currently has both, but is created for the purpose of discussion. I do not necessarily believe that adding everything is a good idea.
PR Details
The workflow is sufficiently generic that it could be ported easily to Forgejo by changing the base
runs-on/"OS" of the job. For testing reasons, the Forgejo Actions specify Codeberg's runner.I'd like to add Woodpecker CI, but testing it is not very easy, as Codeberg's implementation currently requires a manual application and review process.
GitHub Actions' recent addition of
arm64also makes testing for that architecture much easier, though it is important to note that it is currently in "Public Preview".CI-specific information/questions
At the time of writing,
python:3.5andpython:3.6fail with the following line:python:3.4fails with the following line:It is impossible for me to check whether this is expected or not, as there are no logs of previous or current CI runs.