-
Notifications
You must be signed in to change notification settings - Fork 2k
MSD Billing: Wire new cancel flow to v2 purchase page, remove unused v1 components #107255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSD Billing: Wire new cancel flow to v2 purchase page, remove unused v1 components #107255
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~16 bytes removed 📉 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~64 bytes removed 📉 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~14 bytes removed 📉 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/dashboard/me/billing-purchases/purchase-settings/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One thing I immediately notice, though, is that for some reason the breadcrumbs on the cancel page do not include the purchase settings page.
It should look like the "update payment method" page:
I think this may be due to the Nevermind. I'm wrong about that.path property of the cancel route. I see that changePaymentMethodRoute has path: 'payment-method/change' but cancelPurchaseRoute has path: 'cancel'
sirbrillig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |

Closes SHILL-1278
Proposed Changes
Why are these changes being made?
Testing Instructions
/v2/me/billing/purchasesand select a purchase that you'd like to cancel, choosing "Manage purchase" for that row./me/purchasesand select a purchase that you'd like to cancel, choosing "Manage purchase" for that row.Pre-merge Checklist