-
Notifications
You must be signed in to change notification settings - Fork 2k
Added the title property to the pane block. #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage report for
|
St.β |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π’ | Statements | 84.76% (+0.08% πΌ) |
3927/4633 |
| π‘ | Branches | 64.58% (+0.48% πΌ) |
2645/4096 |
| π’ | Functions | 80.41% (+0.11% πΌ) |
714/888 |
| π’ | Lines | 85.25% (+0.08% πΌ) |
3658/4291 |
Test suite run success
767 tests passing in 49 suites.
Report generated by π§ͺjest coverage report action from 92b54d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a title property to the pane block component, allowing users to display text next to the close button in persistent panes.
Key changes:
- Added
titleproperty configuration to backend (viselements.json, factory.py) - Implemented title rendering in the persistent pane header with appropriate styling based on anchor position
- Refactored icon and styling logic into separate helper functions for better code organization
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| taipy/gui/viselements.json | Added title property definition with type, default value, and documentation |
| taipy/gui/_renderers/factory.py | Registered title property as a string type in the pane element builder |
| frontend/taipy-gui/src/components/Taipy/Pane.tsx | Implemented title rendering in header with position-aware styling, refactored icon and style logic into helper functions |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage report for
|
St.β |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π΄ | Statements | 52.71% | 272/516 |
| π΄ | Branches | 21.47% | 67/312 |
| π΄ | Functions | 14.66% | 17/116 |
| π΄ | Lines | 54.09% | 251/464 |
Test suite run success
7 tests passing in 1 suite.
Report generated by π§ͺjest coverage report action from 92b54d7
β¦e top of the page) - Added support anchor string shortcuts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What type of PR is this? (Check all that apply)
Description
The title appears next to the close button in opened persistent panes.