Added the ability to modify default command aliases #2755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've introduced an option that lets you toggle whether we want to use the default command aliases or only those set as command-aliases.
I've tried implementing this several times, but something always went wrong. Only after you added the CommandsMap.clearCommands() method today did I finally succeed. I know it might not be perfect, so please review it carefully and tell me what to modify to improve performance.
I've included the ability to modify aliases while the server is running, so for example, I've modified CommandsManagerImpl.commandsCooldown to store SuperiorCommand instead of String.
Unfortunately, the usage of commands also stores labels, so it's a bit of a hassle to modify them in CommandsHelper, but everything works fine.
Let me know what you think @OmerBenGera , this option will definitely be useful to many people, so it would be good if it could be merged after any fixes 😃