Skip to content

Fix minor bugs in script to update dependencies #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ax3l merged 1 commit into from
Sep 16, 2025
+3 −1
Merged

Fix minor bugs in script to update dependencies #6150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Tools/Release/update_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# License: BSD-3-Clause-LBNL

import argparse
import copy
import datetime
import json
import os
Expand Down Expand Up @@ -83,6 +84,7 @@ def update(args):
tags_response = requests.get(repo_subdict["tags"])
tags_list = tags_response.json()
# filter out old-format tags for specific repositories
tags_list_filtered = copy.deepcopy(tags_list)
Copy link
Member Author

@EZoni EZoni Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this fix tags_list_filtered could be used uninitialized.

if repo_name == "amrex":
tags_list_filtered = [
tag_dict
Expand All @@ -108,7 +110,7 @@ def update(args):
if repo_name != "warpx":
print(f"- old commit: {dependencies_data[commit_key]}")
print(f"- new commit: {new_commit_sha}")
if dependencies_data[commit_key] == repo_commit_sha:
if dependencies_data[commit_key] == new_commit_sha:
Copy link
Member Author

@EZoni EZoni Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new_commit_sha is the variable that contains the correct information (commit sha or version tag).

print("Skipping commit update...")
else:
print("Updating commit...")
Expand Down
Loading