Only use class names for service IDs

Author: mbabker

src/Facades/TwilioClient.php

@@ -27,6 +27,6 @@ final class TwilioClient extends Facade
      */
     protected static function getFacadeAccessor()
     {
-        return 'babdev.twilio.manager';
+        return ConnectionManager::class;
     }
 }

src/Providers/TwilioProvider.php

@@ -24,11 +24,9 @@ final class TwilioProvider extends ServiceProvider implements DeferrableProvider
     public function provides()
     {
         return [
-            'babdev.twilio.manager',
             ConnectionManager::class,
             TwilioClient::class,
 
-            'babdev.twilio.http_client',
             TwilioHttpClient::class,
         ];
     }
@@ -69,14 +67,13 @@ public function register(): void
     private function registerConnectionManager(): void
     {
         $this->app->singleton(
-            'babdev.twilio.manager',
+            ConnectionManager::class,
             static function (Application $app): ConnectionManager {
                 return new ConnectionManager($app);
             }
         );
 
-        $this->app->alias('babdev.twilio.manager', ConnectionManager::class);
-        $this->app->alias('babdev.twilio.manager', TwilioClient::class);
+        $this->app->alias(ConnectionManager::class, TwilioClient::class);
     }
 
     /**
@@ -87,7 +84,7 @@ static function (Application $app): ConnectionManager {
     private function registerHttpClient(): void
     {
         $this->app->bind(
-            'babdev.twilio.http_client',
+            TwilioHttpClient::class,
             static function (Application $app): TwilioHttpClient {
                 // If Guzzle is installed, then we will either use Laravel's native client or Guzzle directly
                 if (\class_exists(Guzzle::class)) {
@@ -103,7 +100,5 @@ static function (Application $app): TwilioHttpClient {
                 return new CurlClient();
             }
         );
-
-        $this->app->alias('babdev.twilio.http_client', TwilioHttpClient::class);
     }
 }

tests/Providers/TwilioProviderTest.php

@@ -3,6 +3,7 @@
 namespace BabDev\Twilio\Tests\Providers;
 
 use BabDev\Twilio\ConnectionManager;
+use BabDev\Twilio\Contracts\TwilioClient;
 use BabDev\Twilio\Providers\TwilioProvider;
 use Illuminate\Support\ServiceProvider;
 use Orchestra\Testbench\TestCase;
@@ -20,8 +21,8 @@ public function testServiceProviderPublishesConfiguration(): void
 
     public function testServicesAreRegistered(): void
     {
-        $this->assertTrue($this->app->bound('babdev.twilio.manager'));
-        $this->assertSame('babdev.twilio.manager', $this->app->getAlias(ConnectionManager::class));
+        $this->assertTrue($this->app->bound(ConnectionManager::class));
+        $this->assertSame(ConnectionManager::class, $this->app->getAlias(TwilioClient::class));
     }
 
     protected function getPackageProviders($app)