Update order use to retrieve terms during resync

Previously when doing a resync, terms were ordered by name which could
cause hierarchy issues when a child term was sync before its parent.
Terms will now be ordered by ID ascending which should ensure parents
are always created before their children.

Author: petitphp

classes/cli/_helper.php

@@ -5,14 +5,14 @@
 }
 
 class BEA_CSF_Cli_Helper {
+
 	/**
-	 *
 	 * Synchronization all terms from any taxonomies
 	 *
 	 * @param array $args
 	 * @param array $terms_args
 	 *
-	 * @return bool
+	 * @return array|bool
 	 */
 	public static function get_all_terms( $args = array(), $terms_args = array() ) {
 		$args = wp_parse_args( $args, array() );
@@ -26,8 +26,15 @@ public static function get_all_terms( $args = array(), $terms_args = array() ) {
 		}
 
 		// Get terms objects
-		$terms_args = wp_parse_args( $terms_args, array( 'hide_empty' => false ) );
-		$results    = get_terms( array_keys( $taxonomies ), $terms_args );
+		$terms_args = wp_parse_args(
+			$terms_args,
+			array(
+				'taxonomy'   => array_keys( $taxonomies ),
+				'hide_empty' => false,
+				'orderby'    => 'term_id',
+			)
+		);
+		$results    = get_terms( $terms_args );
 		if ( is_wp_error( $results ) || empty( $results ) ) {
 			WP_CLI::debug( 'No terms found for taxonomies : %s', implode( ',', array_keys( $taxonomies ) ) );
 
@@ -38,18 +45,24 @@ public static function get_all_terms( $args = array(), $terms_args = array() ) {
 	}
 
 	/**
-	 *
 	 * Synchronization all terms from any taxonomies
 	 *
 	 * @param array $taxonomies
 	 * @param array $terms_args
 	 *
-	 * @return bool
+	 * @return array|bool
 	 */
 	public static function get_terms( $taxonomies = array(), $terms_args = array() ) {
 		// Get terms objects
-		$terms_args = wp_parse_args( $terms_args, array( 'hide_empty' => false ) );
-		$results    = get_terms( $taxonomies, $terms_args );
+		$terms_args = wp_parse_args(
+			$terms_args,
+			array(
+				'taxonomy'   => $taxonomies,
+				'hide_empty' => false,
+				'orderby'    => 'term_id',
+			)
+		);
+		$results    = get_terms( $terms_args );
 		if ( is_wp_error( $results ) || empty( $results ) ) {
 			WP_CLI::debug( 'No terms found for taxonomies : %s', implode( ',', $taxonomies ) );