Set -std=gnu99 for gcc on all architectures #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the cmake file only sets `-std=gnu99` when it is on x86(-64),
which causes compilation failure on other architectures when gcc is
used.
GCC currently defaults to `-std=gnu23`, which would fail the build with:
blosc/shuffle.c:26:15: error: ‘bool’ cannot be defined via ‘typedef’
This patch fixes it by setting `-std=gnu99` for gcc on all
architectures.
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Nov 15, 2025
Set `-std=gnu99` for all architectures to fix build: Blosc/c-blosc#399
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
Nov 15, 2025
Set `-std=gnu99` for all architectures to fix build: Blosc/c-blosc#399
Contributor
|
Why first check if the compiler is gcc? If our code is written in the gnu99 dialect, it should be passed to any compiler. Clang also supports compiling gnu99 code. |
Author
The original code sets it to
That's nice! But I suppose msvc don't support it? |
Contributor
I doubt. But how can it then compile the code? |
kalvdans
approved these changes
Nov 15, 2025
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Nov 17, 2025
Set `-std=gnu99` for all architectures to fix build: Blosc/c-blosc#399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the cmake file only sets
-std=gnu99when it is on x86(-64), which causes compilation failure on other architectures when gcc is used.GCC currently defaults to
-std=gnu23, which would fail the build with:This patch fixes it by setting
-std=gnu99for gcc on all architectures.