Skip to content

Commit ac05ca8

Browse files
author
Bradley Shellnut
committed
Moving envs to integration and adding playwright.
1 parent 8735da7 commit ac05ca8

File tree

2 files changed

+32
-25
lines changed

2 files changed

+32
-25
lines changed

.github/workflows/svelte_integration.yml

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,6 @@ on:
99

1010
workflow_dispatch:
1111

12-
env:
13-
WALLABAG_MAX_ARTICLES: ${{ secrets.WALLABAG_MAX_ARTICLES }}
14-
WALLABAG_MAX_PAGES: ${{ secrets.WALLABAG_MAX_PAGES }}
15-
WALLABAG_CLIENT_ID: ${{ secrets.WALLABAG_CLIENT_ID }}
16-
WALLABAG_CLIENT_SECRET: ${{ secrets.WALLABAG_CLIENT_SECRET }}
17-
WALLABAG_USERNAME: ${{ secrets.WALLABAG_USERNAME }}
18-
WALLABAG_PASSWORD: ${{ secrets.WALLABAG_PASSWORD }}
19-
WALLABAG_URL: ${{ secrets.WALLABAG_URL }}
20-
BANDCAMP_USERNAME: ${{ secrets.BANDCAMP_USERNAME }}
21-
PUBLIC_SITE_URL: ${{ secrets.PUBLIC_SITE_URL }}
22-
PUBLIC_URL: ${{ secrets.PUBLIC_URL }}
23-
PUBLIC_UMAMI_DO_NOT_TRACK: ${{ secrets.PUBLIC_UMAMI_DO_NOT_TRACK }}
24-
PUBLIC_UMAMI_URL: ${{ secrets.PUBLIC_UMAMI_URL }}
25-
PUBLIC_UMAMI_ID: ${{ secrets.PUBLIC_UMAMI_ID }}
26-
PAGE_SIZE: ${{ secrets.PAGE_SIZE }}
27-
USE_REDIS_CACHE: ${{ secrets.USE_REDIS_CACHE }}
28-
REDIS_URI: ${{ secrets.REDIS_URI }}
29-
# Disable Redis during E2E to avoid network/DNS failures in CI preview server
30-
# This overrides secrets above for this workflow job context
31-
# (If you later need Redis in E2E, remove this override.)
32-
E2E_USE_REDIS_CACHE: 'false'
33-
3412
jobs:
3513
e2e-tests:
3614
name: Run end-to-end tests
@@ -54,8 +32,22 @@ jobs:
5432
run: pnpm exec playwright install --with-deps
5533
- name: Run tests
5634
env:
57-
# Force Redis off during E2E regardless of repo secrets
58-
USE_REDIS_CACHE: ${{ env.E2E_USE_REDIS_CACHE }}
35+
WALLABAG_MAX_ARTICLES: ${{ secrets.WALLABAG_MAX_ARTICLES }}
36+
WALLABAG_MAX_PAGES: ${{ secrets.WALLABAG_MAX_PAGES }}
37+
WALLABAG_CLIENT_ID: ${{ secrets.WALLABAG_CLIENT_ID }}
38+
WALLABAG_CLIENT_SECRET: ${{ secrets.WALLABAG_CLIENT_SECRET }}
39+
WALLABAG_USERNAME: ${{ secrets.WALLABAG_USERNAME }}
40+
WALLABAG_PASSWORD: ${{ secrets.WALLABAG_PASSWORD }}
41+
WALLABAG_URL: ${{ secrets.WALLABAG_URL }}
42+
BANDCAMP_USERNAME: ${{ secrets.BANDCAMP_USERNAME }}
43+
PUBLIC_SITE_URL: ${{ secrets.PUBLIC_SITE_URL }}
44+
PUBLIC_URL: ${{ secrets.PUBLIC_URL }}
45+
PUBLIC_UMAMI_DO_NOT_TRACK: ${{ secrets.PUBLIC_UMAMI_DO_NOT_TRACK }}
46+
PUBLIC_UMAMI_URL: ${{ secrets.PUBLIC_UMAMI_URL }}
47+
PUBLIC_UMAMI_ID: ${{ secrets.PUBLIC_UMAMI_ID }}
48+
PAGE_SIZE: ${{ secrets.PAGE_SIZE }}
49+
USE_REDIS_CACHE: 'false'
50+
REDIS_URI: ${{ secrets.REDIS_URI }}
5951
run: pnpm test:integration
6052
- uses: actions/upload-artifact@v4
6153
if: ${{ !cancelled() }}

playwright.config.ts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,22 @@ const config: PlaywrightTestConfig = {
1111
testMatch: /(.+\.)?(test|spec)\.[jt]s/,
1212
use: {
1313
baseURL: 'http://localhost:4173'
14-
}
14+
},
15+
// Run on main browsers: Chromium (Chrome), Firefox, WebKit (Safari)
16+
projects: [
17+
{
18+
name: 'chromium',
19+
use: { browserName: 'chromium' }
20+
},
21+
{
22+
name: 'firefox',
23+
use: { browserName: 'firefox' }
24+
},
25+
{
26+
name: 'webkit',
27+
use: { browserName: 'webkit' }
28+
}
29+
]
1530
};
1631

1732
export default config;

0 commit comments

Comments
 (0)