Technical review Bridging Past and Present: Reconstructing Prince Eugene’s Library through Fuzzy String Matching

[eliselavy]

Pid:
b2uqnD7MTWwh

[eliselavy]

@Nouhabens try to launch the notebook by mybinder and test it

[Nouhabens]

@eliselavy
Did a second preflight but could run it only on Main branch.
https://github.com/jdh-observer/b2uqnD7MTWwh/blob/main/report.md

Second preflight still shows that tables are not tagged: The anchor changes we did for table 1 and 2 are still appearing as figure 1 and 2 on the preview.

[Nouhabens]

@eliselavy
There are 2 tables in hermeneutics, section 1.2.2:
I tagged first one as data-table - since it is a large one - and second one as table-indentation-spacing-entries-*.
Only second one is rendering on the preview (as table 3)

Did the changes on this branch:
https://github.com/jdh-observer/b2uqnD7MTWwh/tree/fix-technical-review

[Nouhabens]

@eliselavy
in the preflight report, section anchors are marked as invalid or missing, but they do link to the correct sections and at least per guidelines, it doesn’t seem to be an error in the tags. Could you please tell me what do I need to inspect there?

[Nouhabens]

@eliselavy
test with mybinder ok - no error when executing cells. Had to install all the libraries used in this article when running the notebook with docker.

[Nouhabens]

@eliselavy in the preflight report, section anchors are marked as invalid or missing, but they do link to the correct sections and at least per guidelines, it doesn’t seem to be an error in the tags. Could you please tell me what do I need to inspect there?

@inactinique :
Fixed anchors to match the same title of the chapters, but paragraph becomes repetitive and heavy. should we ask the author to fix it, or we keep it as it was for the peer review, and we ask the author later?

[Nouhabens]

@eliselavy There are 2 tables in hermeneutics, section 1.2.2: I tagged first one as data-table - since it is a large one - and second one as table-indentation-spacing-entries-*. Only second one is rendering on the preview (as table 3)

Did the changes on this branch: https://github.com/jdh-observer/b2uqnD7MTWwh/tree/fix-technical-review

@eliselavy :
UPDATE: Fixed ✅

[Nouhabens]

@eliselavy Did a second preflight but could run it only on Main branch. https://github.com/jdh-observer/b2uqnD7MTWwh/blob/main/report.md

Second preflight still shows that tables are not tagged: The anchor changes we did for table 1 and 2 are still appearing as figure 1 and 2 on the preview.

@eliselavy : UPDATE : not resolved ❌ - still same issue with figure 1,2 displayed instead of table 1,2.

[Nouhabens]

@eliselavy : issued a pull request.

https://github.com/jdh-observer/b2uqnD7MTWwh/tree/fix-technical-review