Skip to content

Conversation

@efifogel
Copy link
Member

Summary of Changes

This addresses issue #9084. In particular, I replaced Cartesian with Simple_cartesian in all traits.
I also defined Multiplicity to be std::size_t in all traits. In addition, I replaced typedef with using and properly indented and cleaned up the code in the source files I touched. I simplified the code that approximates a point of the traits classes Arr_linear_traits_2, Arr_segment_traits_2, and Arr_non_caching_segment_basic_traits_2.h. I did not use the GAL::Cartesian_coverter (mentioned in issue #9084) because the code is now simple as it is(just one line in each traits class).

I also added a missing inline in draw_arrangement_2. This is unrelated to the above.

Release Management

  • Affected package(s): Arrangement_on_surface_2
  • Issue(s) solved (if any): fix Additional changes for Arrangement traits #9084
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: TAU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional changes for Arrangement traits

2 participants