fix contibutor added unit tests p1

Author: Ostap-Zherebetskyi

api_tests/nodes/views/test_node_contributors_list.py

@@ -1311,7 +1311,7 @@ def test_add_unregistered_contributor_sends_email(
             )
             assert res.status_code == 201
         assert len(notifications['emits']) == 1
-        assert notifications['emits'][0]['type'] == NotificationType.Type.NODE_CONTRIBUTOR_ADDED_DEFAULT
+        assert notifications['emits'][0]['type'] == NotificationType.Type.USER_INVITE_DEFAULT
 
     @mock.patch('website.project.signals.unreg_contributor_added.send')
     def test_add_unregistered_contributor_signal_if_default(
@@ -1333,7 +1333,7 @@ def test_add_unregistered_contributor_signal_if_default(
             )
             assert res.status_code == 201
         assert len(notifications['emits']) == 1
-        assert notifications['emits'][0]['type'] == NotificationType.Type.NODE_CONTRIBUTOR_ADDED_DEFAULT
+        assert notifications['emits'][0]['type'] == NotificationType.Type.USER_INVITE_DEFAULT
 
     def test_add_unregistered_contributor_signal_preprint_email_disallowed(
         self, app, user, url_project_contribs

osf/models/mixins.py

@@ -1541,6 +1541,7 @@ def add_unregistered_contributor(
             fullname,
             email,
             auth,
+            notification_type=False,
             visible=True,
             permissions=None,
             existing_user=None
@@ -1589,17 +1590,18 @@ def add_unregistered_contributor(
             else:
                 raise e
 
-        from osf.models import AbstractNode, Preprint, DraftRegistration
+        if notification_type is None:
+            from osf.models import AbstractNode, Preprint, DraftRegistration
 
-        if isinstance(self, AbstractNode):
-            notification_type = NotificationType.Type.USER_INVITE_DEFAULT
-        elif isinstance(self, Preprint):
-            if self.provider.is_default:
-                notification_type = NotificationType.Type.USER_INVITE_OSF_PREPRINT
-            else:
-                notification_type = NotificationType.Type.PROVIDER_USER_INVITE_PREPRINT
-        elif isinstance(self, DraftRegistration):
-            notification_type = NotificationType.Type.USER_INVITE_DRAFT_REGISTRATION
+            if isinstance(self, AbstractNode):
+                notification_type = NotificationType.Type.USER_INVITE_DEFAULT
+            elif isinstance(self, Preprint):
+                if self.provider.is_default:
+                    notification_type = NotificationType.Type.USER_INVITE_OSF_PREPRINT
+                else:
+                    notification_type = NotificationType.Type.PROVIDER_USER_INVITE_PREPRINT
+            elif isinstance(self, DraftRegistration):
+                notification_type = NotificationType.Type.USER_INVITE_DRAFT_REGISTRATION
 
         self.add_contributor(
             contributor,