[ENG-9793] update unregistered contributor notifications and email templates #11462
+104
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostap-Zherebetskyi
force-pushed
the
fix/invite_unreg_emails
branch
from
8d450fc to
4f652a2
Compare
cslzchen
reviewed
Nov 28, 2025
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Great work on the fix + the templates updates 🎆 I added a few notes and will review again when unit tests are fixed.
| log=True, | ||
| save=False, | ||
| notification_type=NotificationType.Type.NODE_CONTRIBUTOR_ADDED_DEFAULT | ||
| notification_type=False, |
Collaborator
There was a problem hiding this comment.
False: we don't want user to receive any emails
None: we will just wait for the caller to provide the template
Comment on lines
+1598
to
+1606
| if isinstance(self, AbstractNode): | ||
| notification_type = NotificationType.Type.USER_INVITE_DEFAULT | ||
| elif isinstance(self, Preprint): | ||
| if self.provider.is_default: | ||
| notification_type = NotificationType.Type.USER_INVITE_OSF_PREPRINT | ||
| else: | ||
| notification_type = NotificationType.Type.PROVIDER_USER_INVITE_PREPRINT | ||
| elif isinstance(self, DraftRegistration): | ||
| notification_type = NotificationType.Type.USER_INVITE_DRAFT_REGISTRATION |
Collaborator
There was a problem hiding this comment.
Let's remove "unused" comments in the types definition for these ones.
| return | ||
|
|
||
| claim_url = None | ||
| if not contributor.is_confirmed: |
Collaborator
There was a problem hiding this comment.
Note : looks like is_registered , is_confirmed, date_registered and date_confirmed are the same for this check. Let's keep is_confirmed here.
Ostap-Zherebetskyi
force-pushed
the
fix/invite_unreg_emails
branch
from
84ab6de to
7309cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
update unregistered contributor notifications and email templates
Changes
See diff
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-9793