Skip to content

Commit 65dd61b

Browse files
author
Mike Lue
committed
[OWL-2005] Remove logging for debugging late-time alarm data
1 parent 567c578 commit 65dd61b

File tree

3 files changed

+0
-34
lines changed

3 files changed

+0
-34
lines changed

modules/alarm/cron/reader.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ func popEvent(queues []string) (*model.Event, error) {
7171

7272
log.Debug(event.String())
7373
//insert event into database
74-
go warningIfEventTooLate(5, &event)
7574
err = eventmodel.InsertEvent(&event, "owl")
7675
if err != nil {
7776
log.Error(err.Error())
@@ -153,12 +152,3 @@ func popExternalEvent(queues []string) error {
153152

154153
return nil
155154
}
156-
157-
func warningIfEventTooLate(minutes int, event *model.Event) {
158-
now := time.Now()
159-
eventTime := time.Unix(event.EventTime, 0)
160-
161-
if now.Sub(eventTime) >= (time.Duration(minutes) * time.Minute) {
162-
log.Warnf("[DELAY DATA] Event [%v] is delay more than %d minutes. Now: %s. EventTime: %s", event, minutes, now, eventTime)
163-
}
164-
}

modules/judge/store/judge.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import (
55
"fmt"
66
"github.com/Cepave/open-falcon-backend/common/model"
77
"github.com/Cepave/open-falcon-backend/modules/judge/g"
8-
"time"
98
)
109

1110
func Judge(L *SafeLinkedList, firstItem *model.JudgeItem, now int64) {
@@ -81,7 +80,6 @@ func sendEvent(event *model.Event) {
8180
rc := g.RedisConnPool.Get()
8281
defer rc.Close()
8382

84-
go warningIfEventTooLate(5, event)
8583
rc.Do("LPUSH", redisKey, string(bs))
8684
}
8785

@@ -243,12 +241,3 @@ func sendEventIfNeed(historyData []*model.HistoryData, isTriggered bool, now int
243241
}
244242
}
245243
}
246-
247-
func warningIfEventTooLate(minutes int, event *model.Event) {
248-
now := time.Now()
249-
eventTime := time.Unix(event.EventTime, 0)
250-
251-
if now.Sub(eventTime) >= (time.Duration(minutes) * time.Minute) {
252-
log.Warnf("[DELAY DATA] Event [%v] is delay more than %d minutes. Now: %s. EventTime: %s", event, minutes, now, eventTime)
253-
}
254-
}

modules/transfer/sender/send_tasks.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ func forward2JudgeTask(Q *list.SafeListLimited, node string, concurrent int) {
101101
var err error
102102
sendOk := false
103103
for i := 0; i < 3; i++ { //最多重试3次
104-
go warningIfEventTooLate(5, judgeItems)
105104
err = JudgeConnPools.Call(addr, "Judge.Send", judgeItems, resp)
106105
if err == nil {
107106
sendOk = true
@@ -353,15 +352,3 @@ func forward2StagingTask() {
353352
}(stagingItems, count)
354353
}
355354
}
356-
357-
func warningIfEventTooLate(minutes int, metrics []*cmodel.JudgeItem) {
358-
now := time.Now()
359-
360-
for _, metric := range metrics {
361-
metricTime := time.Unix(metric.Timestamp, 0)
362-
363-
if now.Sub(metricTime) >= (time.Duration(minutes) * time.Minute) {
364-
log.Warnf("[DELAY DATA] Metric [%v] is delay more than %d minutes. Now: %s. EventTime: %s", metric, minutes, now, metricTime)
365-
}
366-
}
367-
}

0 commit comments

Comments
 (0)