fix: receipt in eth_getTransactionReceipt is optional

Author: LesnyRumcajs

src/rpc/methods/eth.rs

@@ -2798,7 +2798,7 @@ async fn get_eth_transaction_receipt(
     ctx: Ctx<impl Blockstore + Send + Sync + 'static>,
     tx_hash: EthHash,
     limit: Option<ChainEpoch>,
-) -> Result<EthTxReceipt, ServerError> {
+) -> Result<Option<EthTxReceipt>, ServerError> {
     let msg_cid = ctx.chain_store().get_mapping(&tx_hash)?.unwrap_or_else(|| {
         tracing::debug!(
             "could not find transaction hash {} in Ethereum mapping",
@@ -2812,7 +2812,16 @@ async fn get_eth_transaction_receipt(
         .state_manager
         .search_for_message(None, msg_cid, limit, Some(true))
         .await
-        .with_context(|| format!("failed to lookup Eth Txn {tx_hash} as {msg_cid}"))?;
+        .with_context(|| format!("failed to lookup Eth Txn {tx_hash} as {msg_cid}"));
+
+    let option = match option {
+        Ok(opt) => opt,
+        // Ethereum clients expect an empty response when the message was not found
+        Err(e) => {
+            tracing::debug!("could not find transaction receipt for hash {tx_hash}: {e}");
+            return Ok(None);
+        }
+    };
 
     let (tipset, receipt) = option.context("not indexed")?;
     let ipld = receipt.return_data().deserialize().unwrap_or(Ipld::Null);
@@ -2845,7 +2854,7 @@ async fn get_eth_transaction_receipt(
 
     let tx_receipt = new_eth_tx_receipt(&ctx, &parent_ts, &tx, &message_lookup.receipt).await?;
 
-    Ok(tx_receipt)
+    Ok(Some(tx_receipt))
 }
 
 pub enum EthGetTransactionReceipt {}
@@ -2857,7 +2866,7 @@ impl RpcMethod<1> for EthGetTransactionReceipt {
     const API_PATHS: BitFlags<ApiPaths> = ApiPaths::all_with_v2();
     const PERMISSION: Permission = Permission::Read;
     type Params = (EthHash,);
-    type Ok = EthTxReceipt;
+    type Ok = Option<EthTxReceipt>;
     async fn handle(
         ctx: Ctx<impl Blockstore + Send + Sync + 'static>,
         (tx_hash,): Self::Params,
@@ -2875,7 +2884,7 @@ impl RpcMethod<2> for EthGetTransactionReceiptLimited {
     const API_PATHS: BitFlags<ApiPaths> = ApiPaths::all_with_v2();
     const PERMISSION: Permission = Permission::Read;
     type Params = (EthHash, ChainEpoch);
-    type Ok = EthTxReceipt;
+    type Ok = Option<EthTxReceipt>;
     async fn handle(
         ctx: Ctx<impl Blockstore + Send + Sync + 'static>,
         (tx_hash, limit): Self::Params,