diff --git a/.github/workflows/docs-required-override.yml b/.github/workflows/docs-required-override.yml index 8153dd415c0..566ba6472ec 100644 --- a/.github/workflows/docs-required-override.yml +++ b/.github/workflows/docs-required-override.yml @@ -78,16 +78,6 @@ jobs: steps: - run: echo "No-op job to trigger the required checks." - override_unit_tests: - name: tests - runs-on: ubuntu-24.04-arm - needs: - - changes-docs - - changes-not-docs - if: ${{ (needs.changes-docs.outputs.changesFound == 'true') && (needs.changes-not-docs.outputs.otherChangesFound == 'false') }} - steps: - - run: echo "No-op job to trigger the required checks." - override_unit_tests_release: name: tests-release runs-on: ubuntu-24.04-arm diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 419be02c96c..84511234a1a 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -33,25 +33,6 @@ env: CXX: "sccache clang++" jobs: - tests: - runs-on: ubuntu-24.04-arm - # Run the job only if the PR is not a draft. - # This is done to limit the runner cost. - if: github.event.pull_request.draft == false - timeout-minutes: 45 - steps: - - name: Checkout Sources - uses: actions/checkout@v6 - - name: Setup sccache - uses: mozilla-actions/sccache-action@v0.0.9 - timeout-minutes: ${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }} - continue-on-error: true - - uses: actions/setup-go@v6 - with: - go-version-file: "go.work" - - name: install nextest - uses: taiki-e/install-action@nextest - - run: make test tests-release: runs-on: ubuntu-24.04-arm # Run the job only if the PR is not a draft. @@ -80,7 +61,9 @@ jobs: go-version-file: "go.work" - name: install nextest uses: taiki-e/install-action@nextest - - run: make test-release + - run: | + make test-release-docs + make test-release env: # To minimize compile times: https://nnethercote.github.io/perf-book/build-configuration.html#minimizing-compile-times RUSTFLAGS: "-C linker=clang -C link-arg=-fuse-ld=lld" diff --git a/Makefile b/Makefile index 35beaf3e627..93c230baa92 100644 --- a/Makefile +++ b/Makefile @@ -101,6 +101,7 @@ docker-run: test: cargo nextest run --workspace --no-fail-fast +test-docs: # nextest doesn't run doctests https://github.com/nextest-rs/nextest/issues/16 # see also lib.rs::doctest_private cargo test --doc --features doctest-private @@ -108,10 +109,13 @@ test: test-release: cargo nextest run --cargo-profile quick --workspace --no-fail-fast -test-all: test test-release +test-release-docs: + # nextest doesn't run doctests https://github.com/nextest-rs/nextest/issues/16 + # see also lib.rs::doctest_private + cargo test --profile quick --doc --features doctest-private codecov: - cargo llvm-cov --workspace --codecov --output-path lcov.info --ignore-run-fail + cargo llvm-cov --workspace --codecov --output-path lcov.info # Checks if all headers are present and adds if not license: