Skip to content

Commit 016e25c

Browse files
authored
update simple-dns (paritytech#470)
Upgrades simple-dns from 0.9.3 to 0.11.0. The reason being that we detected segfaults when using this version of simple-dns, here the backtrace ``` Thread 2 "tokio-runtime-w" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ffff71ff6c0 (LWP 662)] 0x00005555590fa234 in simple_dns::dns::packet::Packet::parse_section::hcaf780141803b06c () (gdb) bt #0 0x00005555590fa234 in simple_dns::dns::packet::Packet::parse_section::hcaf780141803b06c () #1 0x0000555558586eb3 in litep2p::protocol::mdns::Mdns::start::{{closure}}::h9dfcac24f1cf526c () #2 0x0000555558582ff0 in litep2p::Litep2p::new::{{closure}}::h7e8ab961e0597d4d () #3 0x00005555568998cf in <tracing_futures::Instrumented<T> as core::future::future::Future>::poll::h14f8d5a4cd2280a5 () paritytech#4 0x0000555556623186 in tokio::runtime::task::raw::poll::h20b62065a828f381 () paritytech#5 0x00005555597c242e in tokio::runtime::scheduler::multi_thread::worker::Context::run_task::hd2657bfbfd77fdd7 () paritytech#6 0x00005555597c0a60 in tokio::runtime::scheduler::multi_thread::worker::run::hff59903bb30ee69e () paritytech#7 0x00005555597c6b05 in tokio::runtime::task::raw::poll::hd94431bf703a75c4 () paritytech#8 0x00005555597af0f8 in std::sys::backtrace::__rust_begin_short_backtrace::h5776829e2c5e1158 () paritytech#9 0x00005555597b3af8 in core::ops::function::FnOnce::call_once{{vtable.shim}}::hd2821905ea35840e () paritytech#10 0x00005555593e4abb in std::sys::pal::unix::thread::Thread::new::thread_start::h1822d22fde68314f () paritytech#11 0x00007ffff7c4d1f5 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 paritytech#12 0x00007ffff7ccd8dc in ?? () from /lib/x86_64-linux-gnu/libc.so.6 ``` We believe it is related to this PR at least partially balliegojr/simple-dns#40 whose changes were introduced here: balliegojr/simple-dns#41 we have confirmed that using 0.11.0 removes the issue.
1 parent 74194e2 commit 016e25c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ prost = "0.13.5"
3333
rand = { version = "0.8.0", features = ["getrandom"] }
3434
serde = "1.0.158"
3535
sha2 = "0.10.9"
36-
simple-dns = "0.9.3"
36+
simple-dns = "0.11.0"
3737
smallvec = "1.15.0"
3838
snow = { version = "0.9.3", features = ["ring-resolver"], default-features = false }
3939
socket2 = { version = "0.5.9", features = ["all"] }

0 commit comments

Comments
 (0)