-
Notifications
You must be signed in to change notification settings - Fork 254
Checkpointing simulations #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ali-ramadhan
wants to merge
30
commits into
main
Choose a base branch
from
ali/checkpointing-that-works
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 13 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
390f24e
First stab at starting to support checkpointing simulations
ali-ramadhan 751072c
Start working on some new tests
ali-ramadhan bc39dd5
Parameterize a couple of tests
ali-ramadhan d131070
Replace old tests
ali-ramadhan ee79883
Fix `archs` for checkpointer tests
ali-ramadhan 30d4ccf
Merge branch 'main' into ali/checkpointing-that-works
ali-ramadhan 0f79241
Merge branch 'main' into ali/checkpointing-that-works
ali-ramadhan c3838da
Checkpointing output writers
ali-ramadhan d721d9b
Checkpointing and restoring Lagrangian particles
ali-ramadhan 50cd623
Checkpoint the hydrostatic model
ali-ramadhan 629381f
Merge branch 'ali/checkpointing-that-works' of github.com:CliMA/Ocean…
ali-ramadhan f6d8bfc
Update src/Models/HydrostaticFreeSurfaceModels/hydrostatic_free_surfa…
ali-ramadhan e155376
Nonhydrostatic diffusivity fields are now called closure fields
ali-ramadhan 71cffaa
Fix model `prognostic_state`
ali-ramadhan 5a1e461
Checkpointing `MultiRegionObject`
ali-ramadhan d4c25bd
Checkpointing for free surfaces
ali-ramadhan 1f6814c
Properly checkpoint simulation to not override new stop criteria
ali-ramadhan 0802088
Merge branch 'main' into ali/checkpointing-that-works
ali-ramadhan 3b3eb39
Checkpoint `SplitRungeKutta3TimeStepper`
ali-ramadhan c512323
Test checkpointing hydrostatic models
ali-ramadhan 4af2871
Merge branch 'ali/checkpointing-that-works' of github.com:CliMA/Ocean…
ali-ramadhan bf03663
Get rid of checkpointer properties
ali-ramadhan 6a7f654
Checkpoint shallow water models
ali-ramadhan d2ef109
Test checkpointing shallow water models
ali-ramadhan 3dbf637
Merge branch 'main' into ali/checkpointing-that-works
ali-ramadhan 4437c23
Fix test archs for CI
ali-ramadhan add807d
Update checkpointing for `ImplicitFreeSurface`
ali-ramadhan 84d3550
Merge branch 'main' into ali/checkpointing-that-works
ali-ramadhan 3f4b6e3
Merge branch 'main' into ali/checkpointing-that-works
ali-ramadhan ba1686f
Merge branch 'main' into ali/checkpointing-that-works
ali-ramadhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we handle this with dispatch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for dispatch I think this may need to know the closure as well. This is a unique object that is "managed" by the closure but doesn't store much identifying info. We could also change that design, but might want to dedicate / test in a prior PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure. Right now I'm still working on getting all the existing tests to pass, but once they do I want to start testing checkpointing more and more complex simulations. As part of it, we should also test closures that use
model.closure_fields.