fixup! ci: check the prebuilt addon binds on every supported Node major

Author: not-matthias

.github/workflows/ci.yml

@@ -31,7 +31,9 @@ jobs:
     runs-on: "ubuntu-latest"
     name: Native addon ABI compatibility
     env:
-      # The flags the runner passes in a real benchmark process.
+      # The flags the runner passes in a real benchmark process. They cannot go
+      # through NODE_OPTIONS (--allow-natives-syntax is rejected there), so jest
+      # runs in-band under a flagged node instead of forking workers.
       NODE_OPTS: "--interpreted-frames-native-stack --allow-natives-syntax"
     steps:
       - uses: "actions/checkout@v4"
@@ -49,26 +51,21 @@ jobs:
           key-suffix: native-abi
       - run: pnpm install --frozen-lockfile --prefer-offline
       # Build one prebuild set, then load it without rebuilding under each
-      # runtime. The other jobs compile the addon with the Node version that
-      # loads it, so they cannot detect an ABI mismatch.
+      # runtime via the jest integ test. The other jobs compile the addon
+      # with the Node version that loads it, so they cannot detect an ABI
+      # mismatch.
       - run: pnpm turbo run build --filter=@codspeed/core
 
       - uses: actions/setup-node@v6
         with:
-          node-version: "22.0.0"
-      - run: node ${{ env.NODE_OPTS }} scripts/assert-native-binding.cjs
+          node-version: "22"
+      - run: node ${{ env.NODE_OPTS }} "$(node -p 'require.resolve("jest/bin/jest")')" -c jest.config.integ.js --runInBand tests/index.integ.test.ts
+        working-directory: packages/core
       - uses: actions/setup-node@v6
         with:
-          node-version: "22.23.2"
-      - run: node ${{ env.NODE_OPTS }} scripts/assert-native-binding.cjs
-      - uses: actions/setup-node@v6
-        with:
-          node-version: "24.0.0"
-      - run: node ${{ env.NODE_OPTS }} scripts/assert-native-binding.cjs
-      - uses: actions/setup-node@v6
-        with:
-          node-version: "24.20.0"
-      - run: node ${{ env.NODE_OPTS }} scripts/assert-native-binding.cjs
+          node-version: "24"
+      - run: node ${{ env.NODE_OPTS }} "$(node -p 'require.resolve("jest/bin/jest")')" -c jest.config.integ.js --runInBand tests/index.integ.test.ts
+        working-directory: packages/core
 
   list-examples:
     runs-on: "ubuntu-latest"

packages/core/tests/index.integ.test.ts

@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-require-imports */
-export {}; // Make this a module
+import fs from "fs";
 
 beforeEach(() => {
   jest.resetModules();
@@ -10,6 +10,25 @@ describe("with bindings", () => {
     const isBound = require("..").isBound as boolean;
     expect(isBound).toBe(true);
   });
+
+  // Symbols in the addon are bound lazily, so a prebuild built against another
+  // ABI loads without complaint and only dies once a V8 entry point runs.
+  it("should write the perf map when the core is set up", () => {
+    const { setupCore, teardownCore } = require("..") as {
+      setupCore: () => void;
+      teardownCore: () => void;
+    };
+    setupCore();
+    teardownCore();
+
+    const perfMap = `/tmp/perf-${process.pid}.map`;
+    const entries = fs
+      .readFileSync(perfMap, "utf8")
+      .split("\n")
+      .filter(Boolean);
+    fs.unlinkSync(perfMap);
+    expect(entries.length).toBeGreaterThan(0);
+  });
 });
 
 describe("without bindings", () => {