Skip to content

Commit 6152fb5

Browse files
ReaderWriterLockSlim sample: .NET 10, Lock field, async pitfall demo, recursion tests (#2323)
1 parent e845b0b commit 6152fb5

7 files changed

Lines changed: 73 additions & 10 deletions

File tree

‎csharp-intermediate-topics/WhenToUseReaderWriterLockSlimOverLockInCSharp/Tests/ReaderWriterLockSlimReadWriteTests.cs‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,39 @@ public void WhenReadOrAdd_ListCountIsEqualOne()
4848

4949
Assert.AreEqual(1, readerWriterLockSlimReadWrite.ListOfNumbers.Count);
5050
}
51+
52+
[TestMethod]
53+
public void WhenReadLockIsEnteredTwiceWithDefaultPolicy_ThrowsLockRecursionException()
54+
{
55+
using var readerWriterLockSlim = new ReaderWriterLockSlim();
56+
readerWriterLockSlim.EnterReadLock();
57+
58+
Assert.ThrowsExactly<LockRecursionException>(() => readerWriterLockSlim.EnterReadLock());
59+
60+
readerWriterLockSlim.ExitReadLock();
61+
}
62+
63+
[TestMethod]
64+
public void WhenReadLockIsEnteredTwiceWithSupportsRecursion_RecursiveReadCountIsTwo()
65+
{
66+
using var readerWriterLockSlim = new ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
67+
readerWriterLockSlim.EnterReadLock();
68+
readerWriterLockSlim.EnterReadLock();
69+
70+
Assert.AreEqual(2, readerWriterLockSlim.RecursiveReadCount);
71+
72+
readerWriterLockSlim.ExitReadLock();
73+
readerWriterLockSlim.ExitReadLock();
74+
}
75+
76+
[TestMethod]
77+
public void WhenReadLockHolderEntersWriteLock_ThrowsLockRecursionException()
78+
{
79+
using var readerWriterLockSlim = new ReaderWriterLockSlim();
80+
readerWriterLockSlim.EnterReadLock();
81+
82+
Assert.ThrowsExactly<LockRecursionException>(() => readerWriterLockSlim.EnterWriteLock());
83+
84+
readerWriterLockSlim.ExitReadLock();
85+
}
5186
}

‎csharp-intermediate-topics/WhenToUseReaderWriterLockSlimOverLockInCSharp/Tests/Tests.csproj‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net7.0</TargetFramework>
4+
<TargetFramework>net10.0</TargetFramework>
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
77

@@ -10,10 +10,10 @@
1010
</PropertyGroup>
1111

1212
<ItemGroup>
13-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.0" />
14-
<PackageReference Include="MSTest.TestAdapter" Version="2.2.10" />
15-
<PackageReference Include="MSTest.TestFramework" Version="2.2.10" />
16-
<PackageReference Include="coverlet.collector" Version="3.2.0" />
13+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
14+
<PackageReference Include="MSTest.TestAdapter" Version="4.5.1" />
15+
<PackageReference Include="MSTest.TestFramework" Version="4.5.1" />
16+
<PackageReference Include="coverlet.collector" Version="10.1.0" />
1717
</ItemGroup>
1818

1919
<ItemGroup>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
namespace WhenToUseReaderWriterLockSlimOverLockInCSharp;
2+
3+
public static class AsyncPitfall
4+
{
5+
public static async Task<string> ExitWriteLockAfterAwait()
6+
{
7+
var readerWriterLockSlim = new ReaderWriterLockSlim();
8+
var threadBefore = Environment.CurrentManagedThreadId;
9+
10+
readerWriterLockSlim.EnterWriteLock();
11+
await Task.Delay(50);
12+
var threadAfter = Environment.CurrentManagedThreadId;
13+
14+
try
15+
{
16+
readerWriterLockSlim.ExitWriteLock();
17+
18+
return $"Exited on the same thread ({threadBefore}).";
19+
}
20+
catch (SynchronizationLockException ex)
21+
{
22+
return $"{ex.GetType().Name} on thread {threadAfter} " +
23+
$"(entered on thread {threadBefore}): {ex.Message}";
24+
}
25+
}
26+
}

‎csharp-intermediate-topics/WhenToUseReaderWriterLockSlimOverLockInCSharp/WhenToUseReaderWriterLockSlimOverLockInCSharp/LockReadWrite.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
public class LockReadWrite : BaseReaderWriter
44
{
5-
private static readonly object LockObject = new();
5+
private static readonly Lock LockObject = new();
66

77
public override void AddNumbersToList(int writerExecutionsCount, int writerExecutionDelay)
88
{

‎csharp-intermediate-topics/WhenToUseReaderWriterLockSlimOverLockInCSharp/WhenToUseReaderWriterLockSlimOverLockInCSharp/Program.cs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,6 @@
1818

1919
var readerWriterLockSlimReadWrite = new ReaderWriterLockSlimReadWrite();
2020
Console.WriteLine($"ReaderWriterLockSlim execution time: " +
21-
$"{readerWriterLockSlimReadWrite.Execute(config)} milliseconds.");
21+
$"{readerWriterLockSlimReadWrite.Execute(config)} milliseconds.");
22+
23+
Console.WriteLine(await AsyncPitfall.ExitWriteLockAfterAwait());

‎csharp-intermediate-topics/WhenToUseReaderWriterLockSlimOverLockInCSharp/WhenToUseReaderWriterLockSlimOverLockInCSharp/ReaderWriterLockSlimReadWrite.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ public override void ReadListCount(int readerExecutionsCount, int readerExecutio
4545

4646
public void ReadOrAdd(int writerExecutionDelay)
4747
{
48-
var random = Random.Shared.Next(0, NumbersList.Count);
49-
5048
ReaderWriterLockSlim.EnterUpgradeableReadLock();
5149

5250
try
5351
{
52+
var random = Random.Shared.Next(0, NumbersList.Count);
53+
5454
if (!NumbersList.Contains(random))
5555
{
5656
ReaderWriterLockSlim.EnterWriteLock();

‎csharp-intermediate-topics/WhenToUseReaderWriterLockSlimOverLockInCSharp/WhenToUseReaderWriterLockSlimOverLockInCSharp/WhenToUseReaderWriterLockSlimOverLockInCSharp.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<OutputType>Exe</OutputType>
5-
<TargetFramework>net7.0</TargetFramework>
5+
<TargetFramework>net10.0</TargetFramework>
66
<ImplicitUsings>enable</ImplicitUsings>
77
<Nullable>enable</Nullable>
88
</PropertyGroup>

0 commit comments

Comments
 (0)