fix: empty block period waiting too long (#1549)

antonydenyer · web-flow · commit aabfccff9826 · 2022-11-04T15:47:32.000Z
diff --git a/consensus/istanbul/qbft/core/request.go b/consensus/istanbul/qbft/core/request.go
@@ -61,7 +61,7 @@ func (c *core) handleRequest(request *Request) error {
 			config := c.config.GetConfig(c.current.Sequence())
 			if config.EmptyBlockPeriod > config.BlockPeriod {
 				log.Info("EmptyBlockPeriod detected adding delay to request", "EmptyBlockPeriod", config.EmptyBlockPeriod, "BlockTime", block.Time())
-				delay = time.Duration(config.EmptyBlockPeriod) * time.Second
+				delay = time.Duration(config.EmptyBlockPeriod-config.BlockPeriod) * time.Second
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func (c core) handleRequest(request Request) error {`
`61`	`61`	`config := c.config.GetConfig(c.current.Sequence())`
`62`	`62`	`if config.EmptyBlockPeriod > config.BlockPeriod {`
`63`	`63`	`log.Info("EmptyBlockPeriod detected adding delay to request", "EmptyBlockPeriod", config.EmptyBlockPeriod, "BlockTime", block.Time())`
`64`		`- delay = time.Duration(config.EmptyBlockPeriod) * time.Second`
	`64`	`+ delay = time.Duration(config.EmptyBlockPeriod-config.BlockPeriod) * time.Second`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`