Fixes regression with pagebreak_in_banner

Author: 1beb

NEWS.md

@@ -1,3 +1,7 @@
+## crunchtabs 1.4.4
+
+- Fixes a regression where absolutelynopagebreak was duplicated in some situations. (pagebreak_in_banner=TRUE and one_per_page=FALSE)
+
 ## crunchtabs 1.4.3
 
 - categorical_arrays were previously spliced into the first position at every question iteration, leading to questions being presented out of vector order in the resulting pdf output. This update patches the results list back together when splicing the array questions in-place. Now, the order of variables is the same as the order presented in the output pdf. (INNOV-498)

R/writeLatex.R

@@ -222,14 +222,11 @@ latexReportTables <- function(results, banner, theme) {
     # bottomrule gets wiped out by nopagebreak environment
     # adding one manually
     if (!theme$pagebreak_in_banner) {
-      # table <- gsub(
-      #   "\\end{longtable}",
-      #   "\\bottomrule\\end{longtable}\n",
-      #   table,
-      #   fixed = TRUE
-      # )
-
-      table <- noBreaks(table)
+      table = gsub(
+        "\\end{longtable}",
+        "\\bottomrule\\end{longtable}\n\\end{absolutelynopagebreak}",
+        table, fixed = TRUE)
+      # table <- noBreaks(table)
     }
 
     table_bodies[[i]] <- table

tests/testthat/test-catArrayToCategoricals.R

@@ -2,7 +2,10 @@ context("catArrayToCategoricals")
 
 test_that("Binds categorical arrays appropriately", {
   questions <- readRDS(test_path("fixtures/catArrayToCategorical_questions.rds"))
-  res <- catArrayToCategoricals(questions, "petloc", labels = NULL)
+  res <- expect_warning(
+    catArrayToCategoricals(questions, "petloc", labels = NULL),
+    "New variables derived from a"
+  )
 
   expect_equal(
     res$petloc_1$crosstabs$Results$`___total___`$proportions,