Implement new interfaces selection for ifup

* The 'no ifaces found matching' exception has been replaced by a quiet early return

Author: Olivier BLIN

ifupdown2/ifupdown/ifupdownmain.py

@@ -1767,7 +1767,7 @@ def _preprocess_excludepats(self, excludepats):
         self.logger.info('excludepats after processing companions [%s]' %' '.join(new_excludepats))
         return new_excludepats
 
-    def up(self, ops, auto=False, allow_classes=None, ifacenames=None,
+    def up(self, ops, all_itf=False, allow_classes=None, ifacenames=None,
            excludepats=None, printdependency=None, syntaxcheck=False,
            type=None, skipupperifaces=False):
         """This brings the interface(s) up
@@ -1790,7 +1790,7 @@ def up(self, ops, auto=False, allow_classes=None, ifacenames=None,
             ifupdownflags.flags.CLASS = True
         if not self.flags.ADDONS_ENABLE:
             self.flags.STATEMANAGER_UPDATE = False
-        if auto:
+        if all_itf:
             ifupdownflags.flags.ALL = True
             ifupdownflags.flags.WITH_DEPENDS = True
         try:
@@ -1801,24 +1801,12 @@ def up(self, ops, auto=False, allow_classes=None, ifacenames=None,
         if excludepats:
             excludepats = self._preprocess_excludepats(excludepats)
 
-        filtered_ifacenames = None
-        if ifacenames:
-            ifacenames = self._preprocess_ifacenames(ifacenames)
-
-            if allow_classes:
-                filtered_ifacenames = self._get_filtered_ifacenames_with_classes(auto, allow_classes, excludepats, ifacenames)
-
-        # if iface list not given by user, assume all from config file
-        if not ifacenames: ifacenames = list(self.ifaceobjdict.keys())
-
-        if not filtered_ifacenames:
-            # filter interfaces based on auto and allow classes
-            filtered_ifacenames = [i for i in ifacenames
-                                    if self._iface_whitelisted(auto, allow_classes,
-                                                excludepats, i)]
+        # Get a filtered list of interfaces to work on
+        filtered_ifacenames = self._get_filtered_ifacenames_with_classes(
+                all_itf, allow_classes, excludepats, ifacenames)
 
         if not filtered_ifacenames:
-            raise Exception('no ifaces found matching given allow lists')
+            return
 
         if printdependency:
             self.populate_dependency_info(ops, filtered_ifacenames)