macOS CI build issues

[RadWolfie]

I recently noticed an issue introduced from the #204 pull request, except the issue isn't from the pull request itself. I reran the CI build on my fork repository with several different attempts to resolve the issue with no luck. After trying again search for a specific keyword such as align didn't come back found. Finally, after searching on the Internet, there's also another keyword to search for which is pack. This then returns two finds:

• https://github.com/Cxbx-Reloaded/XbSymbolDatabase/blob/master/include/Xbe.h
• https://github.com/Cxbx-Reloaded/XbSymbolDatabase/blob/master/src/OOVPADatabase/OOVPA.h

The below redundant message came from the OOVPA.h file. And by commenting pragma pack out cause to fully compiled just fine.
ld: warning: pointer not aligned at address 0x...

I am unsure if the Xbe.h file will also need the fix for the above issue due to an old issue, see side note below.

Side note: I'm still unable to perform CTest on macOS from CI to verify if the build is working or not. The errors:

SimpleIni.h:2217:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.
SimpleIni.h:2279:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.


test/util/helper.hpp:86:34: error: reference to unresolved using declaration
            size_t length = std::c16rtomb(output, pCertificate->wszTitleName[i], &state);
                                 ^

test/main.cpp:900:18: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
    if (test_ret = cliInputInteractive(argc, argv)) {
        ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
test/main.cpp:900:18: note: place parentheses around the assignment to silence this warning
    if (test_ret = cliInputInteractive(argc, argv)) {
                 ^
        (                                         )
test/main.cpp:900:18: note: use '==' to turn this assignment into an equality comparison
    if (test_ret = cliInputInteractive(argc, argv)) {
                 ^
                 ==

• SimpleIni module can be update to 56499b5af5d2195c6acfc58c4630b70e0c9c4c21 commit for resolve sprintf deprecated messages.
• if (test_ret = cliInputInteractive(argc, argv)) { can be update to if ((test_ret = cliInputInteractive(argc, argv))) {

[0Alastair1]

That c16rtomb error also happens on mingw i686 gcc windows.

[RadWolfie]

Yeah, funny thing about that... when I re-enable CTest for macOS, the log output this:

In file included from /Users/runner/work/XbSymbolDatabase/XbSymbolDatabase/src/test/util/helper.hpp:8:
/Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/cuchar:68:1: note: using declaration annotated with 'using_if_exists' here
using ::c16rtomb _LIBCPP_USING_IF_EXISTS;

which describe below comment is upstream yet still can't find reference.

XbSymbolDatabase/CMakeLists.txt

Line 33 in 62dd7eb

# NOTE: llvm Clang contain a fix in https://github.com/llvm/llvm-project/commit/311ff3917827131c20d4b8dac4ce0394a2351b94 commit.

---

That c16rtomb error also happens on mingw i686 gcc windows.

Hmm... The issue also occur on mingw64 except using ucrt64 will work fine.
sources:

• https://stackoverflow.com/questions/57528555/how-do-i-build-against-the-ucrt-with-mingw-w64
• https://github.com/RadWolfie/XbSymbolDatabase/actions/runs/8895187650 (using msys2/setup-msys2 action)
  mingw64 (failed)
  mingw32 (failed)
  ucrt64 (passed)