Distinguish between low value and no value

Author: wzshiming

cmd/patch_evaluator/main.go

@@ -20,7 +20,7 @@ func main() {
 	defer patch.Close()
 
 	evaluator := patch_evaluator.Evaluator{}
-	files, reasons, err := evaluator.Evaluate(patch)
+	files, reasonsLowValue, reasonsNoValue, err := evaluator.Evaluate(patch)
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -30,8 +30,13 @@ func main() {
 		fmt.Printf("\t%s\n", file.NewName)
 	}
 
-	fmt.Printf("valueless: %d\n", len(reasons))
-	for _, reason := range reasons {
+	fmt.Printf("low-value: %d\n", len(reasonsLowValue))
+	for _, reason := range reasonsLowValue {
+		fmt.Printf("\t%s: %s\n", reason.File, reason.Message)
+	}
+
+	fmt.Printf("no-value: %d\n", len(reasonsNoValue))
+	for _, reason := range reasonsNoValue {
 		fmt.Printf("\t%s: %s\n", reason.File, reason.Message)
 	}
 }

evaluator.go

@@ -11,35 +11,47 @@ import (
 type Evaluator struct {
 }
 
-func (e Evaluator) Evaluate(r io.Reader) ([]*gitdiff.File, []*Reasons, error) {
+func (e Evaluator) Evaluate(r io.Reader) ([]*gitdiff.File, []*Reasons, []*Reasons, error) {
 	files, _, err := gitdiff.Parse(r)
 	if err != nil {
-		return nil, nil, err
+		return nil, nil, nil, err
 	}
 
-	filterers := []Filterer{
+	lowValue := []Filterer{
 		FocusSuffixFilterer{".sh", ".bash", ".c", ".go", ".py", ".java", ".cpp", ".h", ".hpp", ".yaml", ".yml"},
-		PrefixFilterer{"vendor/", "test/", "tests/"},
-		ContainsFilterer{"generated", "testdata"},
+		PrefixFilterer{"test/", "tests/"},
 		SuffixFilterer{"_test.go"},
+	}
+
+	noValue := []Filterer{
+		PrefixFilterer{"vendor/"},
+		ContainsFilterer{"generated", "testdata"},
 		CommentFilterer{},
 		EmptyLineFilterer{},
 	}
 
 	filtered := []*gitdiff.File{}
 
-	reasons := []*Reasons{}
+	reasonsLowValue := []*Reasons{}
+
+	reasonsNoValue := []*Reasons{}
 loop:
 	for _, file := range files {
-		for _, filterer := range filterers {
+		for _, filterer := range noValue {
+			if rea := filterer.Filter(file); rea != nil {
+				reasonsNoValue = append(reasonsNoValue, rea)
+				continue loop
+			}
+		}
+		for _, filterer := range lowValue {
 			if rea := filterer.Filter(file); rea != nil {
-				reasons = append(reasons, rea)
+				reasonsLowValue = append(reasonsLowValue, rea)
 				continue loop
 			}
 		}
 		filtered = append(filtered, file)
 	}
-	return filtered, reasons, nil
+	return filtered, reasonsLowValue, reasonsNoValue, nil
 }
 
 var contentDiff = diffmatchpatch.New()