Commit 05da9f9
authored
[ASM] ensure struct is on the stack before passing to native code (#5882)
## Summary of changes
Some crashes where reported where the stack trace showed the error
occurred in the WAF, with the call starting in
`Waf.UpdateWafAndDispose`. A review of this method spotted that a
pointer to a struct stored in a object field was being passed to the
WAF. This meant the GC might move the object, which could potentially
lead to a crash.1 parent fb2335d commit 05da9f9
File tree
4 files changed
+5
-4
lines changed- tracer/src/Datadog.Trace/AppSec
- WafEncoding
- Waf
4 files changed
+5
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
| 139 | + | |
| 140 | + | |
140 | 141 | | |
141 | 142 | | |
142 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
690 | 690 | | |
691 | 691 | | |
692 | 692 | | |
693 | | - | |
| 693 | + | |
694 | 694 | | |
695 | 695 | | |
696 | 696 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
334 | 334 | | |
335 | 335 | | |
336 | 336 | | |
337 | | - | |
| 337 | + | |
338 | 338 | | |
339 | 339 | | |
340 | 340 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
0 commit comments