Skip to content

Commit 2e89a5e

Browse files
Revert "Swap to Datadog as default propagation style (#4420)" (#4442)
This reverts commit aff06a7.
1 parent 7efc2de commit 2e89a5e

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

tracer/src/Datadog.Trace/Configuration/TracerSettings.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te
272272
if (PropagationStyleInject.Length == 0)
273273
{
274274
// default value
275-
PropagationStyleInject = new[] { ContextPropagationHeaderStyle.Datadog };
275+
PropagationStyleInject = new[] { ContextPropagationHeaderStyle.W3CTraceContext, ContextPropagationHeaderStyle.Datadog };
276276
}
277277

278278
var propagationStyleExtract = config
@@ -284,7 +284,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te
284284
if (PropagationStyleExtract.Length == 0)
285285
{
286286
// default value
287-
PropagationStyleExtract = new[] { ContextPropagationHeaderStyle.Datadog };
287+
PropagationStyleExtract = new[] { ContextPropagationHeaderStyle.W3CTraceContext, ContextPropagationHeaderStyle.Datadog };
288288
}
289289

290290
// If Activity support is enabled, we must enable the W3C Trace Context propagators.

tracer/test/Datadog.Trace.Tests/Configuration/ConfigurationSourceTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ public static IEnumerable<object[]> GetDefaultTestData()
8484
yield return new object[] { CreateFunc(s => s.MaxTracesSubmittedPerSecond), 100 };
8585
yield return new object[] { CreateFunc(s => s.TracerMetricsEnabled), false };
8686
yield return new object[] { CreateFunc(s => s.Exporter.DogStatsdPort), 8125 };
87-
yield return new object[] { CreateFunc(s => s.PropagationStyleInject), new[] { "Datadog" } };
88-
yield return new object[] { CreateFunc(s => s.PropagationStyleExtract), new[] { "Datadog" } };
87+
yield return new object[] { CreateFunc(s => s.PropagationStyleInject), new[] { "tracecontext", "Datadog" } };
88+
yield return new object[] { CreateFunc(s => s.PropagationStyleExtract), new[] { "tracecontext", "Datadog" } };
8989
yield return new object[] { CreateFunc(s => s.ServiceNameMappings), null };
9090

9191
yield return new object[] { CreateFunc(s => s.TraceId128BitGenerationEnabled), false };

tracer/test/Datadog.Trace.Tests/Configuration/TracerSettingsTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -630,10 +630,10 @@ public void IsActivityListenerEnabled(string value, string fallbackValue, bool e
630630

631631
[Theory]
632632
[InlineData("test1,, ,test2", "test3,, ,test4", "test5,, ,test6", new[] { "test1", "test2" })]
633-
[InlineData("", "test3,, ,test4", "test5,, ,test6", new[] { "Datadog" })]
633+
[InlineData("", "test3,, ,test4", "test5,, ,test6", new[] { "tracecontext", "Datadog" })]
634634
[InlineData(null, "test3,, ,test4", "test5,, ,test6", new[] { "test3", "test4" })]
635635
[InlineData(null, null, "test5,, ,test6", new[] { "test5", "test6" })]
636-
[InlineData(null, null, null, new[] { "Datadog" })]
636+
[InlineData(null, null, null, new[] { "tracecontext", "Datadog" })]
637637
public void PropagationStyleInject(string value, string legacyValue, string fallbackValue, string[] expected)
638638
{
639639
const string legacyKey = "DD_PROPAGATION_STYLE_INJECT";
@@ -654,10 +654,10 @@ public void PropagationStyleInject(string value, string legacyValue, string fall
654654

655655
[Theory]
656656
[InlineData("test1,, ,test2", "test3,, ,test4", "test5,, ,test6", new[] { "test1", "test2" })]
657-
[InlineData("", "test3,, ,test4", "test5,, ,test6", new[] { "Datadog" })]
657+
[InlineData("", "test3,, ,test4", "test5,, ,test6", new[] { "tracecontext", "Datadog" })]
658658
[InlineData(null, "test3,, ,test4", "test5,, ,test6", new[] { "test3", "test4" })]
659659
[InlineData(null, null, "test5,, ,test6", new[] { "test5", "test6" })]
660-
[InlineData(null, null, null, new[] { "Datadog" })]
660+
[InlineData(null, null, null, new[] { "tracecontext", "Datadog" })]
661661
public void PropagationStyleExtract(string value, string legacyValue, string fallbackValue, string[] expected)
662662
{
663663
const string legacyKey = "DD_PROPAGATION_STYLE_EXTRACT";

0 commit comments

Comments
 (0)