File tree Expand file tree Collapse file tree 1 file changed +6
-7
lines changed
tracer/src/Datadog.Trace/Configuration Expand file tree Collapse file tree 1 file changed +6
-7
lines changed Original file line number Diff line number Diff line change @@ -135,13 +135,12 @@ private MutableSettings(
135135 public ReadOnlyDictionary < string , string > HeaderTags { get ; }
136136
137137 // Additional settings that can be set in code
138-
139- // TODO: This one will be hard, we should likely consider something completely different to handle these changes
140- // public const string AgentUriKey = "DD_TRACE_AGENT_URL";
141-
142- // TODO: this one is a problem - it can be changed in code, but the data pipeline needs to be enabled/disabled based on it
143- // we will likely need to make a breaking change so that it _can't_ be changed in code
144- // public const string StatsComputationEnabledKey = "DD_TRACE_STATS_COMPUTATION_ENABLED";
138+ // NOTE: this includes everything except:
139+ // - DD_TRACE_AGENT_URL; This can be set in code, but is handled separately in TracerSettings
140+ // - DD_TRACE_STATS_COMPUTATION_ENABLED; This can currently be set in code, but it's problematic for
141+ // various reasons related to data pipeline, so this change makes it so that you CAN'T set the value
142+ // in code, despite the API appearing to let you. The change is addressed via documentation, and
143+ // in the future we should remove the property entirely (or at least mark it as obsolete)
145144
146145 /// <summary>
147146 /// Gets a value indicating whether the diagnostic log at startup is enabled
You can’t perform that action at this time.
0 commit comments