Commit 8b611d9
## Summary of changes
Adds a stage to `create_draft_release` that verifies the gitlab stages
all passed before starting the release
## Reason for change
Before we merged #5818 we were testing the lib injection images prior to
publishing, but that PR removed the checks (we're building/testing
everything in the one pipeline instead)
This PR, _explicitly_ checks that everything passed in GitLab before
starting the release.
## Implementation details
Pulls all the statuses for the commit, and makes sure the GitLab ones
all have a passing status.
Pros:
- If/when the one-pipeline expands, we automatically check for success.
- One pipeline can change (add/remove checks) and we automatically make
sure they all passed before doing a release.
Cons:
- The one pipeline could break at some point without being a _real_
issue, which would block our releases. So added an override we can use
in case of emergency. It should only be used when the reporting is
"false" though, because the one pipeline creates and publishes the SSI
artifacts.
- We don't explicitly require any of the checks. This gives us
flexibility (they can add or remove checks) but we won't know if we're
actually checking them all (for example)
- If the GitHub/GitLab link isn't working (due to issues either side),
we might not be notified about failures
## Test coverage
Tested locally to confirm the `VerifyReleaseReadiness` works as
expected. e.g. run
```powershell
.\tracer\build.ps1 VerifyReleaseReadiness -CommitSha 89bf7b3 -GITHUB_TOKEN <your token>
```
and it passes, but `ec735117ceaa963d5033f83ed80daaa88f970867` fails (for
example)
## Other details
Backport of #5865
---------
Co-authored-by: Kevin Gosse <[email protected]>
1 parent 2b17318 commit 8b611d9
File tree
3 files changed
+83
-0
lines changed- .github/workflows
- .nuke
- tracer/build/_build
3 files changed
+83
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | 13 | | |
11 | 14 | | |
| |||
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
| 467 | + | |
467 | 468 | | |
468 | 469 | | |
469 | 470 | | |
| |||
677 | 678 | | |
678 | 679 | | |
679 | 680 | | |
| 681 | + | |
680 | 682 | | |
681 | 683 | | |
682 | 684 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
1103 | 1104 | | |
1104 | 1105 | | |
1105 | 1106 | | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
1106 | 1178 | | |
1107 | 1179 | | |
1108 | 1180 | | |
| |||
0 commit comments