Skip to content

Commit 925d913

Browse files
committed
Revert "update debugger type and forwarding based on new logic"
This reverts commit 3e1344c.
1 parent 3e1344c commit 925d913

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

tracer/src/Datadog.Trace/Debugger/ExceptionAutoInstrumentation/ExceptionReplaySnapshotCreator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public ExceptionReplaySnapshotCreator(bool isFullSnapshot, ProbeLocation locatio
3030

3131
internal static string FrameIndex { get; } = Guid.NewGuid().ToString();
3232

33-
internal override string DebuggerType => DebuggerTags.DebuggerType.ExceptionReplaySnapshot;
33+
internal override string DebuggerProduct => DebuggerTags.DebuggerProduct.ER;
3434

3535
internal override DebuggerSnapshotCreator EndSnapshot()
3636
{

tracer/src/Datadog.Trace/Debugger/Models/Snapshot.cs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,19 @@ internal static class DebuggerTags
5656
/// </summary>
5757
internal static class DebuggerType
5858
{
59-
internal const string DynamicInstrumentationSnapshot = "di_snapshot";
60-
internal const string ExceptionReplaySnapshot = "er_snapshot";
59+
internal const string Snapshot = "snapshot";
6160
internal const string Diagnostic = "diagnostic";
6261
internal const string SymDb = "symdb";
6362
}
63+
64+
/// <summary>
65+
/// Tags for debugger.product
66+
/// </summary>
67+
internal static class DebuggerProduct
68+
{
69+
internal const string DI = "di";
70+
internal const string ER = "er";
71+
internal const string LD = "ld";
72+
}
6473
}
6574
}

tracer/src/Datadog.Trace/Debugger/Snapshots/DebuggerSnapshotCreator.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public DebuggerSnapshotCreator(bool isFullSnapshot, ProbeLocation location, bool
6666
MethodScopeMembers = methodScopeMembers;
6767
}
6868

69-
internal virtual string DebuggerType => DebuggerTags.DebuggerType.DynamicInstrumentationSnapshot;
69+
internal virtual string DebuggerProduct => DebuggerTags.DebuggerProduct.DI;
7070

7171
internal string SnapshotId
7272
{
@@ -883,7 +883,10 @@ internal DebuggerSnapshotCreator AddGeneralInfo(string service, string traceId,
883883
JsonWriter.WriteValue(spanId);
884884

885885
JsonWriter.WritePropertyName("debugger.type");
886-
JsonWriter.WriteValue(DebuggerType);
886+
JsonWriter.WriteValue(DebuggerTags.DebuggerType.Snapshot);
887+
888+
JsonWriter.WritePropertyName("debugger.product");
889+
JsonWriter.WriteValue(DebuggerProduct);
887890

888891
return this;
889892
}

tracer/src/Datadog.Trace/Debugger/Upload/DebuggerUploadApiBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ namespace Datadog.Trace.Debugger.Upload;
1919

2020
internal abstract class DebuggerUploadApiBase : IBatchUploadApi
2121
{
22-
private const string DebuggerV1Endpoint = "debugger/v1/input";
22+
protected const string DebuggerV1Endpoint = "debugger/v1/input";
2323

2424
private readonly IApiRequestFactory _apiRequestFactory;
2525
private readonly IGitMetadataTagsProvider? _gitMetadataTagsProvider;

0 commit comments

Comments
 (0)