Skip to content

Commit 9657cae

Browse files
authored
Remove MemberNotNull to fix build (#6699)
## Summary of changes Updated VS and MSBuild locally and can no longer build. ## Reason for change Build wasn't working and I think these are covered as we have nullable enabled and `MetricsHostname` is get only ## Implementation details Delete ## Test coverage Build works now ## Other details <!-- Fixes #{issue} --> <!-- ⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. -->
1 parent c63ed2c commit 9657cae

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

tracer/src/Datadog.Trace/Configuration/ExporterSettings.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,6 @@ bool TryGetMetricsUriAndTransport(string metricsUrl, out MetricsTransportSetting
361361
}
362362

363363
#if NETCOREAPP3_1_OR_GREATER
364-
[MemberNotNull(nameof(MetricsHostname))]
365364
bool SetUds(string unixSocket, string original, string absoluteUri, string? source, out MetricsTransportSettings settings)
366365
{
367366
// Only called in the constructor;
@@ -385,7 +384,6 @@ bool SetUds(string unixSocket, string original, string absoluteUri, string? sour
385384
return probablyValid;
386385
}
387386
#endif
388-
[MemberNotNull(nameof(MetricsHostname))]
389387
bool SetUdp(string hostname, string? hostnameSource, int port, string? portSource, out MetricsTransportSettings settings)
390388
{
391389
var probablyValid = true;

0 commit comments

Comments
 (0)