Skip to content

Commit ad0a291

Browse files
Fix CleanObjFiles job (#7648)
## Summary of changes In some pipeline runs ([here ](https://dev.azure.com/datadoghq/a51c4863-3eb4-4c5d-878a-58b41a049e4e/_apis/build/builds/188976/logs/8606)or [here](https://dev.azure.com/datadoghq/dd-trace-dotnet/_build/results?buildId=188541&view=logs&j=fd641748-8e22-57f1-aa9a-ee8347989a27&t=130ed49b-ad6b-5195-397f-7907ba77a13c)), we are getting the following error: ``` Starting: Run 'CleanObjFiles' in Docker ============================================================================== Task : Command line Description : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows Version : 2.250.1 Author : Microsoft Corporation Help : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line ============================================================================== Generating script. ========================== Starting Command Output =========================== /usr/bin/bash --noprofile --norc /mnt/vss/_work/_temp/091f2bee-2a9e-456c-a12e-fd0574d2a12e.sh Using SDK version 10.0.100-rc.1.25451.107 /mnt/vss/_work/_temp/091f2bee-2a9e-456c-a12e-fd0574d2a12e.sh: line 9: TestAllPackageVersions: command not found /mnt/vss/_work/_temp/091f2bee-2a9e-456c-a12e-fd0574d2a12e.sh: line 9: IncludeMinorPackageVersions: command not found docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to apply cgroup configuration: unable to start unit "docker-38cc23ebfc71d2d7f6f4df0fe154251ca6aab0ce223dfcf56c3a4ed35da88086.scope" (properties [{Name:Description Value:"libcontainer container 38cc23ebfc71d2d7f6f4df0fe154251ca6aab0ce223dfcf56c3a4ed35da88086"} {Name:Slice Value:"system.slice"} {Name:Delegate Value:true} {Name:PIDs Value:@au [11499]} {Name:MemoryAccounting Value:true} {Name:CPUAccounting Value:true} {Name:IOAccounting Value:true} {Name:TasksAccounting Value:true} {Name:DefaultDependencies Value:false}]): Message recipient disconnected from message bus without replying: unknown Run 'docker run --help' for more information ##[error]Bash exited with code '125'. Finishing: Run 'CleanObjFiles' in Docker ``` In order to fix this error, Call sites can set retryCountForRunCommand: 3 for steps sensitive to the occasional OCI runtime create failed / Message recipient disconnected from message bus error. ## Reason for change ## Implementation details ## Test coverage ## Other details <!-- Fixes #{issue} --> <!-- ⚠️ Note: Where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. MergeQueue is NOT enabled in this repository. If you have write access to the repo, the PR has 1-2 approvals (see above), and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #apm-dotnet channel in Slack. -->
1 parent 927af68 commit ad0a291

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.azure-pipelines/ultimate-pipeline.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3402,6 +3402,7 @@ stages:
34023402
build: true
34033403
baseImage: $(baseImage)
34043404
command: "CleanObjFiles"
3405+
retryCountForRunCommand: 3
34053406

34063407
- template: steps/restore-working-directory.yml
34073408
parameters:

tracer/src/Datadog.Trace/Util/RequestDataHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ internal static QueryString GetQueryString(HttpRequest request)
4444
#endif
4545

4646
#if NETFRAMEWORK
47-
// Get the values from a request NameValueCollection
47+
// Gets the values from a request NameValueCollection
4848
internal static string[]? GetNameValueCollectionValues(NameValueCollection queryString, string key)
4949
{
5050
try

0 commit comments

Comments
 (0)