Add tests for disabling host logging

Author: bouwkast

tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/AzureFunctionsTests.cs

@@ -278,6 +278,13 @@ public IsolatedRuntimeV4(ITestOutputHelper output)
         [Trait("RunOnWindows", "True")]
         public async Task SubmitsTraces()
         {
+            // by default host logs are enabled e.g.,
+            // DD_LOGS_DIRECT_SUBMISSION_AZURE_FUNCTIONS_HOST_ENABLED=true
+            // but we do just want a lot of logging, so still bump up the level to VERBOSE
+            SetEnvironmentVariable("DD_LOGS_DIRECT_SUBMISSION_MINIMUM_LEVEL", "VERBOSE");
+            var hostName = "integration_ilogger_az_tests";
+            using var logsIntake = new MockLogsIntake();
+            EnableDirectLogSubmission(logsIntake.Port, nameof(IntegrationId.ILogger), hostName);
             using var agent = EnvironmentHelper.GetMockAgent(useTelemetry: true);
             using (await RunAzureFunctionAndWaitForExit(agent, expectedExitCode: -1))
             {
@@ -286,10 +293,61 @@ public async Task SubmitsTraces()
                 var filteredSpans = spans.Where(s => !s.Resource.Equals("Timer ExitApp", StringComparison.OrdinalIgnoreCase)).ToImmutableList();
 
                 using var s = new AssertionScope();
-
                 await AssertIsolatedSpans(filteredSpans);
 
                 filteredSpans.Count.Should().Be(expectedSpanCount);
+
+                var logs = logsIntake.Logs;
+
+                // ~327 (ish) logs but we kill func.exe so some logs are lost
+                // and since sometimes the batch of logs can be 100+ it can be a LOT of logs that we lose
+                // so just check that we have more than the 13 that we get when host logs are disabled
+                logs.Should().HaveCountGreaterThanOrEqualTo(200);
+            }
+        }
+    }
+
+    // The reason why we have a separate application here is because we run into a Singleton locking issue when
+    // we re-run the same function application in the same test session.
+    // I couldn't find a way to reset the state between test runs, so the easiest solution was to
+    // just create a separate function app.
+    [UsesVerify]
+    [Collection(nameof(AzureFunctionsTestsCollection))]
+    public class IsolatedRuntimeV4HostLogsDisabled : AzureFunctionsTests
+    {
+        public IsolatedRuntimeV4HostLogsDisabled(ITestOutputHelper output)
+            : base("AzureFunctions.V4Isolated.HostLogsDisabled", output)
+        {
+            SetEnvironmentVariable("FUNCTIONS_WORKER_RUNTIME", "dotnet-isolated");
+            SetEnvironmentVariable("FUNCTIONS_EXTENSION_VERSION", "~4");
+        }
+
+        [SkippableFact]
+        [Trait("Category", "EndToEnd")]
+        [Trait("Category", "AzureFunctions")]
+        [Trait("RunOnWindows", "True")]
+        public async Task SubmitsTraces()
+        {
+            SetEnvironmentVariable("DD_LOGS_DIRECT_SUBMISSION_AZURE_FUNCTIONS_HOST_ENABLED", "false");
+            SetEnvironmentVariable("DD_LOGS_DIRECT_SUBMISSION_MINIMUM_LEVEL", "VERBOSE");
+            var hostName = "integration_ilogger_az_tests";
+            using var logsIntake = new MockLogsIntake();
+            EnableDirectLogSubmission(logsIntake.Port, nameof(IntegrationId.ILogger), hostName);
+
+            using var agent = EnvironmentHelper.GetMockAgent(useTelemetry: true);
+            using (await RunAzureFunctionAndWaitForExit(agent, expectedExitCode: -1))
+            {
+                const int expectedSpanCount = 21;
+                var spans = await agent.WaitForSpansAsync(expectedSpanCount);
+
+                var filteredSpans = spans.Where(s => !s.Resource.Equals("Timer ExitApp", StringComparison.OrdinalIgnoreCase)).ToImmutableList();
+
+                await AssertIsolatedSpans(filteredSpans, filename: $"{nameof(AzureFunctionsTests)}.Isolated.V4.HostLogsDisabled");
+                filteredSpans.Count.Should().Be(expectedSpanCount);
+
+                var logs = logsIntake.Logs;
+                // we expect some logs still from the worker process
+                logs.Should().HaveCount(13);
             }
         }
     }
@@ -325,6 +383,8 @@ public async Task SubmitsTraces()
                 // value so they may be removed from being traced.
                 var filteredSpans = FilterOutSocketsHttpHandler(spans);
 
+                filteredSpans = filteredSpans.Where(s => !s.Resource.Equals("Timer ExitApp", StringComparison.OrdinalIgnoreCase)).ToImmutableList();
+
                 using var s = new AssertionScope();
 
                 await AssertIsolatedSpans(filteredSpans.ToImmutableList(), $"{nameof(AzureFunctionsTests)}.Isolated.V4.AspNetCore");

tracer/test/snapshots/AzureFunctionsTests.Isolated.V4.AspNetCore.verified.txt

@@ -317,7 +317,7 @@
 Microsoft.Azure.WebJobs.Host.FunctionInvocationException: Exception while executing function: Functions.Exception
 ---> Microsoft.Azure.WebJobs.Script.Workers.Rpc.RpcException: Result: Failure
 Exception: Task failed successfully.
-Stack:    at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req, ILogger log)
+Stack:    at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req)
 at Samples.AzureFunctions.V4Isolated.AspNetCore.DirectFunctionExecutor.ExecuteAsync(FunctionContext context),
       error.type: Microsoft.Azure.WebJobs.Host.FunctionInvocationException,
       http.method: GET,
@@ -470,7 +470,7 @@ at Samples.AzureFunctions.V4Isolated.AspNetCore.DirectFunctionExecutor.ExecuteAs
       error.msg: Task failed successfully.,
       error.stack:
 System.InvalidOperationException: Task failed successfully.
-at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req, ILogger log),
+at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req),
       error.type: System.InvalidOperationException,
       language: dotnet,
       runtime-id: Guid_1,

tracer/test/snapshots/AzureFunctionsTests.Isolated.V4.AspNetCore1.verified.txt

@@ -317,7 +317,7 @@
 Microsoft.Azure.WebJobs.Host.FunctionInvocationException: Exception while executing function: Functions.Exception
 ---> Microsoft.Azure.WebJobs.Script.Workers.Rpc.RpcException: Result: Failure
 Exception: System.InvalidOperationException: Task failed successfully.
-at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req, ILogger log),
+at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req),
       error.type: Microsoft.Azure.WebJobs.Host.FunctionInvocationException,
       http.method: GET,
       http.request.headers.host: localhost:00000,
@@ -469,7 +469,7 @@ at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req,
       error.msg: Task failed successfully.,
       error.stack:
 System.InvalidOperationException: Task failed successfully.
-at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req, ILogger log),
+at Samples.AzureFunctions.AllTriggers.AllTriggers.Exception(HttpRequestData req),
       error.type: System.InvalidOperationException,
       language: dotnet,
       runtime-id: Guid_1,