Skip to content

Code Changes from Chat Message e9f3da92-30a5-4a61-a25f-9ababfa69039 #7193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Code Changes from Chat Message e9f3da92-30a5-4a61-a25f-9ababfa69039 #7193

wants to merge 1 commit into from

Conversation

@datadog-datadog-prod-us1
Copy link

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 bot commented Jul 8, 2025

PR by Bits for chat ea5e918b-c905-4dfa-a2d8-e40c9550cd66.

You can ask for changes by mentioning @DataDog in a comment.

Feedback (especially what can be better) welcome in #code-gen-feedback!

@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Jul 8, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jul 8, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7193) - mean (74ms)  : 72, 75
     .   : milestone, 74,
    master - mean (74ms)  : 72, 75
     .   : milestone, 74,

    section Baseline
    This PR (7193) - mean (70ms)  : 67, 74
     .   : milestone, 70,
    master - mean (70ms)  : 67, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (7193) - mean (1,029ms)  : 1004, 1055
     .   : milestone, 1029,
    master - mean (1,032ms)  : 1009, 1055
     .   : milestone, 1032,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7193) - mean (108ms)  : 106, 109
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section Baseline
    This PR (7193) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (106ms)  : 104, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7193) - mean (718ms)  : 699, 736
     .   : milestone, 718,
    master - mean (718ms)  : 696, 740
     .   : milestone, 718,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7193) - mean (95ms)  : 94, 97
     .   : milestone, 95,
    master - mean (95ms)  : 93, 97
     .   : milestone, 95,

    section Baseline
    This PR (7193) - mean (94ms)  : 92, 96
     .   : milestone, 94,
    master - mean (94ms)  : 92, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7193) - mean (682ms)  : 656, 707
     .   : milestone, 682,
    master - mean (681ms)  : 661, 701
     .   : milestone, 681,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7193) - mean (192ms)  : 187, 197
     .   : milestone, 192,
    master - mean (191ms)  : 186, 196
     .   : milestone, 191,

    section Baseline
    This PR (7193) - mean (187ms)  : 180, 195
     .   : milestone, 187,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7193) - mean (1,106ms)  : 1073, 1139
     .   : milestone, 1106,
    master - mean (1,112ms)  : 1073, 1150
     .   : milestone, 1112,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7193) - mean (264ms)  : 255, 273
     .   : milestone, 264,
    master - mean (269ms)  : 263, 275
     .   : milestone, 269,

    section Baseline
    This PR (7193) - mean (265ms)  : 257, 274
     .   : milestone, 265,
    master - mean (266ms)  : 257, 275
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (7193) - mean (879ms)  : 853, 905
     .   : milestone, 879,
    master - mean (879ms)  : 852, 905
     .   : milestone, 879,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7193) - mean (259ms)  : 252, 267
     .   : milestone, 259,
    master - mean (260ms)  : 250, 270
     .   : milestone, 260,

    section Baseline
    This PR (7193) - mean (258ms)  : 250, 266
     .   : milestone, 258,
    master - mean (262ms)  : 253, 271
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7193) - mean (868ms)  : 820, 915
     .   : milestone, 868,
    master - mean (872ms)  : 836, 907
     .   : milestone, 872,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7193) - mean (260ms)  : 253, 266
     .   : milestone, 260,
    master - mean (259ms)  : 250, 267
     .   : milestone, 259,

    section Baseline
    This PR (7193) - mean (261ms)  : 254, 269
     .   : milestone, 261,
    master - mean (258ms)  : 249, 268
     .   : milestone, 258,

    section CallTarget+Inlining+NGEN
    This PR (7193) - mean (779ms)  : 756, 803
     .   : milestone, 779,
    master - mean (782ms)  : 754, 810
     .   : milestone, 782,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Jul 8, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7193 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.206
  • 41 benchmarks have fewer allocations
  • 7 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.69 KB -66 B -1.15%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.5 KB -76 B -1.36%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7193 StartStopWithChild net6.0 10.7μs 49.2ns 190ns 0 0 0 5.5 KB
#7193 StartStopWithChild netcoreapp3.1 13.8μs 66.8ns 267ns 0 0 0 5.69 KB
#7193 StartStopWithChild net472 22.1μs 121ns 687ns 0.962 0.214 0 6.11 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7193 WriteAndFlushEnrichedTraces net6.0 931μs 222ns 860ns 0 0 0 2.7 KB
#7193 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 958ns 3.71μs 0 0 0 2.7 KB
#7193 WriteAndFlushEnrichedTraces net472 1.23ms 68.9ns 248ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.66 KB 3.3 KB 1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.17 KB 3.3 KB 1.38%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7193 AllCycleSimpleBody net6.0 333μs 480ns 1.86μs 0 0 0 197.61 KB
#7193 AllCycleSimpleBody netcoreapp3.1 496μs 1.14μs 4.42μs 0 0 0 205.37 KB
#7193 AllCycleSimpleBody net472 444μs 197ns 764ns 37.9 2.23 0 239.66 KB
#7193 AllCycleMoreComplexBody net6.0 343μs 477ns 1.85μs 0 0 0 201.12 KB
#7193 AllCycleMoreComplexBody netcoreapp3.1 504μs 1.94μs 7.5μs 0 0 0 208.78 KB
#7193 AllCycleMoreComplexBody net472 455μs 129ns 498ns 37.9 2.23 0 243.17 KB
#7193 ObjectExtractorSimpleBody net6.0 321ns 0.102ns 0.396ns 0 0 0 280 B
#7193 ObjectExtractorSimpleBody netcoreapp3.1 399ns 2.22ns 14ns 0 0 0 272 B
#7193 ObjectExtractorSimpleBody net472 308ns 0.0221ns 0.0766ns 0.0433 0 0 281 B
#7193 ObjectExtractorMoreComplexBody net6.0 6.31μs 32.5ns 159ns 0 0 0 3.78 KB
#7193 ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 36.1ns 140ns 0 0 0 3.69 KB
#7193 ObjectExtractorMoreComplexBody net472 6.79μs 0.758ns 2.84ns 0.578 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7193 EncodeArgs net6.0 76.8μs 328ns 1.23μs 0 0 0 32.4 KB
#7193 EncodeArgs netcoreapp3.1 100μs 354ns 1.37μs 0 0 0 32.4 KB
#7193 EncodeArgs net472 109μs 42ns 163ns 4.91 0 0 32.51 KB
#7193 EncodeLegacyArgs net6.0 147μs 76.2ns 295ns 0 0 0 2.15 KB
#7193 EncodeLegacyArgs netcoreapp3.1 197μs 37.2ns 144ns 0 0 0 2.15 KB
#7193 EncodeLegacyArgs net472 260μs 44.9ns 168ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7193 RunWafRealisticBenchmark net6.0 270μs 50.7ns 196ns 0 0 0 4.55 KB
#7193 RunWafRealisticBenchmark netcoreapp3.1 291μs 55.3ns 207ns 0 0 0 4.48 KB
#7193 RunWafRealisticBenchmark net472 308μs 33.3ns 125ns 0 0 0 4.66 KB
#7193 RunWafRealisticBenchmarkWithAttack net6.0 181μs 53.6ns 208ns 0 0 0 2.24 KB
#7193 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 194μs 50.9ns 183ns 0 0 0 2.22 KB
#7193 RunWafRealisticBenchmarkWithAttack net472 206μs 19.3ns 69.4ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7193 SendRequest net6.0 61.4μs 50.4ns 182ns 0 0 0 14.52 KB
#7193 SendRequest netcoreapp3.1 70.8μs 62.1ns 232ns 0 0 0 17.42 KB
#7193 SendRequest net472 0.0117ns 0.00298ns 0.0115ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
#7193 OriginalCharSlice net6.0 1.88ms 4.65μs 18μs 0 0 0 640 KB
#7193 OriginalCharSlice netcoreapp3.1 2.09ms 677ns 2.34μs 0 0 0 640 KB
#7193 OriginalCharSlice net472 2.77ms 453ns 1.57μs 100 0 0 641.95 KB
#7193 OptimizedCharSlice net6.0 1.6ms 287ns 1.11μs 0 0 0 2 B
#7193 OptimizedCharSlice netcoreapp3.1 1.69ms 216ns 837ns 0 0 0 1 B
#7193 OptimizedCharSlice net472 1.99ms 312ns 1.21μs 0 0 0 73 B
#7193 OptimizedCharSliceWithPool net6.0 797μs 35.4ns 137ns 0 0 0 3 B
#7193 OptimizedCharSliceWithPool netcoreapp3.1 857μs 49.3ns 191ns 0 0 0 0 b
#7193 OptimizedCharSliceWithPool net472 1.16ms 78.1ns 303ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7193

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.133 631,437.50 715,344.74

More allocations ⚠️ in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.17 KB 413 B 0.74%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.89 KB 42.14 KB 253 B 0.60%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7193 WriteAndFlushEnrichedTraces net6.0 673μs 1.59μs 6.16μs 0 0 0 41.75 KB
#7193 WriteAndFlushEnrichedTraces netcoreapp3.1 707μs 3.84μs 22.1μs 0 0 0 42.14 KB
#7193 WriteAndFlushEnrichedTraces net472 1.02ms 4.6μs 18.4μs 4.46 0 0 56.17 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7193 ExecuteNonQuery net6.0 1.99μs 6.72ns 26ns 0 0 0 1.02 KB
#7193 ExecuteNonQuery netcoreapp3.1 2.57μs 6.11ns 23.7ns 0 0 0 1.02 KB
#7193 ExecuteNonQuery net472 2.85μs 5.75ns 22.3ns 0.154 0.014 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7193 CallElasticsearch net6.0 1.82μs 0.738ns 2.56ns 0 0 0 1.03 KB
#7193 CallElasticsearch netcoreapp3.1 2.29μs 11ns 46.5ns 0 0 0 1.03 KB
#7193 CallElasticsearch net472 3.7μs 1.99ns 7.71ns 0.148 0 0 1.04 KB
#7193 CallElasticsearchAsync net6.0 1.82μs 8.19ns 31.7ns 0 0 0 1.01 KB
#7193 CallElasticsearchAsync netcoreapp3.1 2.59μs 6.09ns 23.6ns 0 0 0 1.08 KB
#7193 CallElasticsearchAsync net472 3.69μs 6.22ns 24.1ns 0.167 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7193 ExecuteAsync net6.0 1.81μs 7.07ns 27.4ns 0 0 0 952 B
#7193 ExecuteAsync netcoreapp3.1 2.35μs 10.1ns 39.2ns 0 0 0 952 B
#7193 ExecuteAsync net472 2.59μs 1.89ns 7.31ns 0.133 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7193 SendAsync net6.0 6.9μs 14.2ns 55.1ns 0 0 0 2.36 KB
#7193 SendAsync netcoreapp3.1 8.4μs 13.4ns 51.7ns 0 0 0 2.9 KB
#7193 SendAsync net472 12.6μs 7.58ns 29.4ns 0.502 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7193

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.283 413,700.00 530,700.00

More allocations ⚠️ in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 277.53 KB 17.57 KB 6.76%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 44.43 KB 600 B 1.37%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 43.06 KB 424 B 0.99%

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7193 StringConcatBenchmark net6.0 44.7μs 220ns 1.41μs 0 0 0 44.43 KB
#7193 StringConcatBenchmark netcoreapp3.1 54.5μs 704ns 7.04μs 0 0 0 43.06 KB
#7193 StringConcatBenchmark net472 57.3μs 248ns 930ns 0 0 0 57.34 KB
#7193 StringConcatAspectBenchmark net6.0 480μs 2.33μs 10.2μs 0 0 0 277.53 KB
#7193 StringConcatAspectBenchmark netcoreapp3.1 534μs 2.61μs 10.8μs 0 0 0 274.02 KB
#7193 StringConcatAspectBenchmark net472 402μs 2.07μs 9.72μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7193 EnrichedLog net6.0 2.62μs 1.94ns 7.5ns 0 0 0 1.7 KB
#7193 EnrichedLog netcoreapp3.1 3.41μs 6.84ns 26.5ns 0 0 0 1.7 KB
#7193 EnrichedLog net472 4μs 6.09ns 23.6ns 0.258 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.52 KB -55 B -1.20%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -58 B -1.33%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7193 EnrichedLog net6.0 122μs 68.6ns 257ns 0 0 0 4.31 KB
#7193 EnrichedLog netcoreapp3.1 129μs 339ns 1.27μs 0 0 0 4.31 KB
#7193 EnrichedLog net472 166μs 181ns 701ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7193 EnrichedLog net6.0 5.07μs 13.7ns 53ns 0 0 0 2.26 KB
#7193 EnrichedLog netcoreapp3.1 6.72μs 14.4ns 55.8ns 0 0 0 2.26 KB
#7193 EnrichedLog net472 7.38μs 4.33ns 16.2ns 0.296 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7193 SendReceive net6.0 2.01μs 3.21ns 12.4ns 0 0 0 1.2 KB
#7193 SendReceive netcoreapp3.1 2.65μs 13.3ns 58.2ns 0 0 0 1.2 KB
#7193 SendReceive net472 3.08μs 1.24ns 4.65ns 0.184 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7193 EnrichedLog net6.0 4.19μs 13.2ns 49.3ns 0 0 0 1.58 KB
#7193 EnrichedLog netcoreapp3.1 5.55μs 11.6ns 43.4ns 0 0 0 1.63 KB
#7193 EnrichedLog net472 6.41μs 6.16ns 23.1ns 0.319 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7193 StartFinishSpan net6.0 742ns 1.63ns 5.89ns 0 0 0 576 B
#7193 StartFinishSpan netcoreapp3.1 962ns 0.593ns 2.3ns 0 0 0 576 B
#7193 StartFinishSpan net472 954ns 0.387ns 1.4ns 0.0904 0 0 578 B
#7193 StartFinishScope net6.0 901ns 4.62ns 21.7ns 0 0 0 696 B
#7193 StartFinishScope netcoreapp3.1 1.21μs 6.52ns 33.9ns 0 0 0 696 B
#7193 StartFinishScope net472 1.09μs 1.25ns 4.68ns 0.1 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7193

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7193 RunOnMethodBegin net6.0 1.04μs 2.85ns 11ns 0 0 0 696 B
#7193 RunOnMethodBegin netcoreapp3.1 1.35μs 6.53ns 27.7ns 0 0 0 696 B
#7193 RunOnMethodBegin net472 1.41μs 1.4ns 5.42ns 0.0987 0 0 658 B

@bouwkast
Copy link
Collaborator

bouwkast commented Oct 3, 2025

Closing as I don't see how this is applicable

@bouwkast bouwkast closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:profiler Issues related to the continous-profiler Bits AI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bouwkast