Skip to content

[WIP] DSM Throughput Default Scenario #7206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[WIP] DSM Throughput Default Scenario #7206

wants to merge 3 commits into from

Conversation

@robcarlan-datadog
Copy link
Contributor

@robcarlan-datadog robcarlan-datadog commented Jul 10, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jul 10, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7206) - mean (77ms)  : 75, 78
     .   : milestone, 77,
    master - mean (75ms)  : 74, 77
     .   : milestone, 75,

    section Baseline
    This PR (7206) - mean (72ms)  : 70, 75
     .   : milestone, 72,
    master - mean (71ms)  : 67, 75
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (7206) - mean (1,052ms)  : 1031, 1073
     .   : milestone, 1052,
    master - mean (1,038ms)  : 1010, 1066
     .   : milestone, 1038,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7206) - mean (114ms)  : 111, 117
     .   : milestone, 114,
    master - mean (113ms)  : 111, 115
     .   : milestone, 113,

    section Baseline
    This PR (7206) - mean (114ms)  : 110, 117
     .   : milestone, 114,
    master - mean (111ms)  : 107, 114
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (7206) - mean (737ms)  : 714, 760
     .   : milestone, 737,
    master - mean (724ms)  : 712, 736
     .   : milestone, 724,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7206) - mean (103ms)  : 100, 105
     .   : milestone, 103,
    master - mean (99ms)  : 96, 102
     .   : milestone, 99,

    section Baseline
    This PR (7206) - mean (101ms)  : 98, 104
     .   : milestone, 101,
    master - mean (97ms)  : 95, 100
     .   : milestone, 97,

    section CallTarget+Inlining+NGEN
    This PR (7206) - mean (701ms)  : 679, 723
     .   : milestone, 701,
    master - mean (682ms)  : 662, 702
     .   : milestone, 682,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7206) - mean (209ms)  : 203, 216
     .   : milestone, 209,
    master - mean (204ms)  : 196, 212
     .   : milestone, 204,

    section Baseline
    This PR (7206) - mean (203ms)  : 192, 213
     .   : milestone, 203,
    master - mean (201ms)  : 193, 209
     .   : milestone, 201,

    section CallTarget+Inlining+NGEN
    This PR (7206) - mean (1,182ms)  : 1151, 1212
     .   : milestone, 1182,
    master - mean (1,170ms)  : 1140, 1199
     .   : milestone, 1170,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7206) - mean (289ms)  : 279, 299
     .   : milestone, 289,
    master - mean (289ms)  : 279, 299
     .   : milestone, 289,

    section Baseline
    This PR (7206) - mean (290ms)  : 277, 302
     .   : milestone, 290,
    master - mean (289ms)  : 279, 298
     .   : milestone, 289,

    section CallTarget+Inlining+NGEN
    This PR (7206) - mean (940ms)  : 911, 970
     .   : milestone, 940,
    master - mean (936ms)  : 904, 968
     .   : milestone, 936,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7206) - mean (283ms)  : 272, 294
     .   : milestone, 283,
    master - mean (283ms)  : 274, 292
     .   : milestone, 283,

    section Baseline
    This PR (7206) - mean (284ms)  : 272, 296
     .   : milestone, 284,
    master - mean (282ms)  : 273, 292
     .   : milestone, 282,

    section CallTarget+Inlining+NGEN
    This PR (7206) - mean (930ms)  : 901, 958
     .   : milestone, 930,
    master - mean (928ms)  : 897, 959
     .   : milestone, 928,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7206) - mean (288ms)  : 274, 303
     .   : milestone, 288,
    master - mean (284ms)  : 274, 293
     .   : milestone, 284,

    section Baseline
    This PR (7206) - mean (287ms)  : 275, 299
     .   : milestone, 287,
    master - mean (282ms)  : 271, 294
     .   : milestone, 282,

    section CallTarget+Inlining+NGEN
    This PR (7206) - mean (846ms)  : 803, 889
     .   : milestone, 846,
    master - mean (834ms)  : 802, 867
     .   : milestone, 834,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7206 compared to master:

  • 7 benchmarks are slower, with geometric mean 1.442
  • 44 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.51 KB -64 B -1.15%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6.01 KB -80 B -1.31%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.67 KB -87 B -1.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7206 StartStopWithChild net6.0 11.1μs 56.9ns 267ns 0 0 0 5.51 KB
#7206 StartStopWithChild netcoreapp3.1 13.9μs 13.9ns 53.7ns 0 0 0 5.67 KB
#7206 StartStopWithChild net472 22.2μs 121ns 734ns 0.896 0.112 0 6.01 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7206 WriteAndFlushEnrichedTraces net6.0 924μs 400ns 1.55μs 0 0 0 2.72 KB
#7206 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 162ns 627ns 0 0 0 2.7 KB
#7206 WriteAndFlushEnrichedTraces net472 1.23ms 2.29μs 8.88μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.66 KB 3.3 KB 1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.17 KB 3.3 KB 1.38%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7206 AllCycleSimpleBody net6.0 332μs 120ns 466ns 0 0 0 197.61 KB
#7206 AllCycleSimpleBody netcoreapp3.1 482μs 1.11μs 3.84μs 0 0 0 205.37 KB
#7206 AllCycleSimpleBody net472 446μs 104ns 403ns 36.6 2.16 0 239.66 KB
#7206 AllCycleMoreComplexBody net6.0 338μs 1.57μs 6.07μs 0 0 0 201.12 KB
#7206 AllCycleMoreComplexBody netcoreapp3.1 507μs 1.06μs 4.11μs 0 0 0 208.78 KB
#7206 AllCycleMoreComplexBody net472 453μs 111ns 385ns 37.9 2.23 0 243.17 KB
#7206 ObjectExtractorSimpleBody net6.0 319ns 0.15ns 0.58ns 0 0 0 280 B
#7206 ObjectExtractorSimpleBody netcoreapp3.1 395ns 2.14ns 12.3ns 0 0 0 272 B
#7206 ObjectExtractorSimpleBody net472 301ns 0.0537ns 0.208ns 0.0444 0 0 281 B
#7206 ObjectExtractorMoreComplexBody net6.0 6.35μs 9.27ns 35.9ns 0 0 0 3.78 KB
#7206 ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 20.7ns 77.4ns 0 0 0 3.69 KB
#7206 ObjectExtractorMoreComplexBody net472 6.77μs 5.48ns 21.2ns 0.577 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7206 EncodeArgs net6.0 76.3μs 365ns 1.46μs 0 0 0 32.4 KB
#7206 EncodeArgs netcoreapp3.1 96.7μs 108ns 419ns 0 0 0 32.4 KB
#7206 EncodeArgs net472 112μs 16.9ns 65.3ns 5.06 0 0 32.51 KB
#7206 EncodeLegacyArgs net6.0 143μs 81.5ns 305ns 0 0 0 2.15 KB
#7206 EncodeLegacyArgs netcoreapp3.1 197μs 214ns 827ns 0 0 0 2.14 KB
#7206 EncodeLegacyArgs net472 261μs 44ns 170ns 0 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7206

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net6.0 1.600 181,119.78 289,829.14
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 1.528 198,578.46 303,420.88
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 1.527 206,733.04 315,771.33
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net6.0 1.442 271,505.69 391,550.50
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑net472 1.423 306,857.62 436,653.66
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 1.402 293,157.49 410,959.79

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7206 RunWafRealisticBenchmark net6.0 392μs 50.5ns 189ns 0 0 0 4.56 KB
#7206 RunWafRealisticBenchmark netcoreapp3.1 411μs 174ns 674ns 0 0 0 4.48 KB
#7206 RunWafRealisticBenchmark net472 437μs 99.3ns 371ns 0 0 0 4.66 KB
#7206 RunWafRealisticBenchmarkWithAttack net6.0 290μs 23.7ns 91.6ns 0 0 0 2.24 KB
#7206 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 303μs 288ns 1.11μs 0 0 0 2.22 KB
#7206 RunWafRealisticBenchmarkWithAttack net472 316μs 47.7ns 165ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7206 SendRequest net6.0 62.1μs 62.8ns 235ns 0 0 0 14.52 KB
#7206 SendRequest netcoreapp3.1 70.9μs 112ns 403ns 0 0 0 17.43 KB
#7206 SendRequest net472 0.0154ns 0.00221ns 0.00857ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
#7206 OriginalCharSlice net6.0 1.89ms 1.77μs 6.38μs 0 0 0 640.01 KB
#7206 OriginalCharSlice netcoreapp3.1 2.11ms 5.69μs 22μs 0 0 0 640 KB
#7206 OriginalCharSlice net472 2.64ms 204ns 734ns 100 0 0 641.95 KB
#7206 OptimizedCharSlice net6.0 1.43ms 98.3ns 381ns 0 0 0 7 B
#7206 OptimizedCharSlice netcoreapp3.1 1.79ms 183ns 708ns 0 0 0 1 B
#7206 OptimizedCharSlice net472 1.99ms 539ns 2.09μs 0 0 0 0 b
#7206 OptimizedCharSliceWithPool net6.0 860μs 33.5ns 130ns 0 0 0 1 B
#7206 OptimizedCharSliceWithPool netcoreapp3.1 801μs 177ns 686ns 0 0 0 0 b
#7206 OptimizedCharSliceWithPool net472 1.16ms 32ns 120ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7206 WriteAndFlushEnrichedTraces net6.0 688μs 3.4μs 14μs 0 0 0 41.69 KB
#7206 WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 3.58μs 20.6μs 0 0 0 41.93 KB
#7206 WriteAndFlushEnrichedTraces net472 888μs 3.71μs 17.8μs 8.33 0 0 55.95 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7206 ExecuteNonQuery net6.0 1.91μs 0.959ns 3.71ns 0 0 0 1.02 KB
#7206 ExecuteNonQuery netcoreapp3.1 2.5μs 5.89ns 22.8ns 0 0 0 1.02 KB
#7206 ExecuteNonQuery net472 2.69μs 2.07ns 8.01ns 0.147 0.0133 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7206 CallElasticsearch net6.0 1.84μs 9.37ns 41.9ns 0 0 0 1.03 KB
#7206 CallElasticsearch netcoreapp3.1 2.25μs 11.5ns 51.6ns 0 0 0 1.03 KB
#7206 CallElasticsearch net472 3.68μs 1.71ns 6.41ns 0.166 0 0 1.04 KB
#7206 CallElasticsearchAsync net6.0 1.86μs 8.65ns 35.7ns 0 0 0 1.01 KB
#7206 CallElasticsearchAsync netcoreapp3.1 2.55μs 6.79ns 26.3ns 0 0 0 1.08 KB
#7206 CallElasticsearchAsync net472 3.76μs 1.8ns 6.48ns 0.169 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7206 ExecuteAsync net6.0 1.87μs 0.89ns 3.33ns 0 0 0 952 B
#7206 ExecuteAsync netcoreapp3.1 2.32μs 6.6ns 25.6ns 0 0 0 952 B
#7206 ExecuteAsync net472 2.67μs 1.74ns 6.75ns 0.133 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7206 SendAsync net6.0 6.82μs 17.7ns 66.1ns 0 0 0 2.36 KB
#7206 SendAsync netcoreapp3.1 8.49μs 16.9ns 65.4ns 0 0 0 2.9 KB
#7206 SendAsync net472 12.4μs 14.2ns 55.1ns 0.497 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7206

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.206 413,700.00 498,800.00

More allocations ⚠️ in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 44.2 KB 1.56 KB 3.66%

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 258.5 KB -1.46 KB -0.56%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 43.44 KB -392 B -0.89%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 255.85 KB -19.08 KB -6.94%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7206 StringConcatBenchmark net6.0 42μs 209ns 862ns 0 0 0 43.44 KB
#7206 StringConcatBenchmark netcoreapp3.1 48.3μs 314ns 2.93μs 0 0 0 44.2 KB
#7206 StringConcatBenchmark net472 57.4μs 183ns 686ns 0 0 0 65.54 KB
#7206 StringConcatAspectBenchmark net6.0 474μs 2.3μs 9.5μs 0 0 0 258.5 KB
#7206 StringConcatAspectBenchmark netcoreapp3.1 502μs 2.34μs 9.07μs 0 0 0 255.85 KB
#7206 StringConcatAspectBenchmark net472 405μs 2.06μs 9.66μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7206 EnrichedLog net6.0 2.7μs 2.24ns 8.68ns 0 0 0 1.7 KB
#7206 EnrichedLog netcoreapp3.1 3.59μs 12.8ns 49.5ns 0 0 0 1.7 KB
#7206 EnrichedLog net472 3.78μs 3.83ns 14.8ns 0.247 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.52 KB -55 B -1.20%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7206 EnrichedLog net6.0 124μs 90.6ns 326ns 0 0 0 4.31 KB
#7206 EnrichedLog netcoreapp3.1 128μs 347ns 1.3μs 0 0 0 4.31 KB
#7206 EnrichedLog net472 167μs 39.2ns 136ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7206 EnrichedLog net6.0 5.05μs 3.67ns 14.2ns 0 0 0 2.26 KB
#7206 EnrichedLog netcoreapp3.1 6.94μs 18.2ns 70.3ns 0 0 0 2.26 KB
#7206 EnrichedLog net472 7.67μs 5.29ns 20.5ns 0.308 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7206 SendReceive net6.0 2.04μs 0.644ns 2.23ns 0 0 0 1.2 KB
#7206 SendReceive netcoreapp3.1 2.64μs 13.2ns 57.4ns 0 0 0 1.2 KB
#7206 SendReceive net472 3.29μs 2.04ns 7.05ns 0.18 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7206 EnrichedLog net6.0 4.27μs 10.1ns 39ns 0 0 0 1.58 KB
#7206 EnrichedLog netcoreapp3.1 5.54μs 7.43ns 28.8ns 0 0 0 1.63 KB
#7206 EnrichedLog net472 6.49μs 8.68ns 33.6ns 0.292 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7206 StartFinishSpan net6.0 752ns 0.271ns 1.05ns 0 0 0 576 B
#7206 StartFinishSpan netcoreapp3.1 968ns 4.77ns 19.1ns 0 0 0 576 B
#7206 StartFinishSpan net472 892ns 0.703ns 2.72ns 0.0897 0 0 578 B
#7206 StartFinishScope net6.0 909ns 4.64ns 21.7ns 0 0 0 696 B
#7206 StartFinishScope netcoreapp3.1 1.26μs 6.01ns 25.5ns 0 0 0 696 B
#7206 StartFinishScope net472 1.1μs 2.58ns 10ns 0.103 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7206

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7206 RunOnMethodBegin net6.0 1.07μs 2.97ns 11.5ns 0 0 0 696 B
#7206 RunOnMethodBegin netcoreapp3.1 1.43μs 5.61ns 21.7ns 0 0 0 696 B
#7206 RunOnMethodBegin net472 1.36μs 1.12ns 4.33ns 0.101 0 0 658 B

@robcarlan-datadog robcarlan-datadog changed the title [WIP] DSM Throughput Default Scenario, Post PR Comment [WIP] DSM Throughput Default Scenario Jul 29, 2025
@bouwkast
Copy link
Collaborator

bouwkast commented Oct 3, 2025

Closing as stale

@bouwkast bouwkast closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robcarlan-datadog @bouwkast