Skip to content

Conversation

@igoragoli
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7538) - mean (69ms)  : 62, 77
     .   : milestone, 69,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (1,002ms)  : 976, 1028
     .   : milestone, 1002,
    master - mean (1,000ms)  : 974, 1026
     .   : milestone, 1000,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (106ms)  : 105, 108
     .   : milestone, 106,

    section Baseline
    This PR (7538) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (105ms)  : 103, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (708ms)  : 691, 725
     .   : milestone, 708,
    master - mean (706ms)  : 683, 729
     .   : milestone, 706,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 94
     .   : milestone, 94,

    section Baseline
    This PR (7538) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (667ms)  : 647, 687
     .   : milestone, 667,
    master - mean (665ms)  : 648, 682
     .   : milestone, 665,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (93ms)  : 91, 94
     .   : milestone, 93,
    master - mean (93ms)  : 91, 94
     .   : milestone, 93,

    section Baseline
    This PR (7538) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (596ms)  : 587, 605
     .   : milestone, 596,
    master - mean (600ms)  : 586, 615
     .   : milestone, 600,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (195ms)  : 192, 198
     .   : milestone, 195,

    section Baseline
    This PR (7538) - mean (190ms)  : 184, 196
     .   : milestone, 190,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (1,095ms)  : 1056, 1135
     .   : milestone, 1095,
    master - mean (1,107ms)  : 1077, 1138
     .   : milestone, 1107,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (274ms)  : 266, 283
     .   : milestone, 274,
    master - mean (275ms)  : 269, 280
     .   : milestone, 275,

    section Baseline
    This PR (7538) - mean (271ms)  : 264, 279
     .   : milestone, 271,
    master - mean (274ms)  : 268, 281
     .   : milestone, 274,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (890ms)  : 848, 932
     .   : milestone, 890,
    master - mean (890ms)  : 852, 928
     .   : milestone, 890,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (266ms)  : 258, 274
     .   : milestone, 266,
    master - mean (269ms)  : 263, 275
     .   : milestone, 269,

    section Baseline
    This PR (7538) - mean (265ms)  : 259, 272
     .   : milestone, 265,
    master - mean (268ms)  : 262, 274
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (877ms)  : 842, 912
     .   : milestone, 877,
    master - mean (877ms)  : 845, 909
     .   : milestone, 877,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7538) - mean (266ms)  : 261, 272
     .   : milestone, 266,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section Baseline
    This PR (7538) - mean (265ms)  : 260, 270
     .   : milestone, 265,
    master - mean (267ms)  : 262, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (7538) - mean (783ms)  : 761, 805
     .   : milestone, 783,
    master - mean (790ms)  : 768, 811
     .   : milestone, 790,

Loading

This reverts commit 702b0fe.
@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:builds project files, build scripts, pipelines, versioning, releases, packages area:docs area:tests unit tests, integration tests area:opentracing area:installers area:vendors Code from other vendors area:shared-components area:profiler Issues related to the continous-profiler area:debugger area:data-streams-monitoring area:integrations labels Sep 19, 2025
@bouwkast
Copy link
Collaborator

bouwkast commented Oct 3, 2025

Closing this as it looks to be an empty PR now

@bouwkast bouwkast closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages area:data-streams-monitoring area:debugger area:docs area:installers area:integrations area:opentracing area:profiler Issues related to the continous-profiler area:shared-components area:tests unit tests, integration tests area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:vendors Code from other vendors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants