-
Notifications
You must be signed in to change notification settings - Fork 151
Cosmos DB partial integration testing #7752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,662
−817
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4ac946b
Run cosmos tests on emulator
pablomartinezbernardo fa2633d
.net fx compat
pablomartinezbernardo 430984c
Use the correct image, protocol https, specific container for arm, an…
pablomartinezbernardo 6cab3f2
Hostname scrubbers
pablomartinezbernardo a1420e1
3.12.0 should also be tested
pablomartinezbernardo d0c60f4
Avoid unnecessary diff changes
pablomartinezbernardo 695e33f
LimitToEndpoint = true && SkipInCI
pablomartinezbernardo 508ee5e
Separate sample app for vnext CI tests
pablomartinezbernardo e2ef73d
Grab versions from actual integration
pablomartinezbernardo b18c93e
Re-generate files after merge
pablomartinezbernardo fbe044c
Apply suggestion from @lucaspimentel
pablomartinezbernardo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -686,6 +686,21 @@ | |
| "ExcludeTargetFrameworks": ["netcoreapp2.1", "netcoreapp3.0"] | ||
| }] | ||
| }, | ||
| { | ||
| "IntegrationName": "CosmosDbVnext", | ||
| "SampleProjectName": "Samples.CosmosDb.Vnext", | ||
| "NugetPackageSearchName": "Microsoft.Azure.Cosmos", | ||
| "MinVersion": "3.12.0", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to use |
||
| "MaxVersionExclusive": "4.0.0", | ||
| "SpecificVersions": [ | ||
| "3.12.*", | ||
| "3.*.*" | ||
| ], | ||
| "VersionConditions": [{ | ||
| "MinVersion": "3.29.0", | ||
| "ExcludeTargetFrameworks": ["netcoreapp2.1", "netcoreapp3.0"] | ||
| }] | ||
| }, | ||
| { | ||
| "IntegrationName": "Serilog", | ||
| "SampleProjectName": "LogsInjection.Serilog", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will require a VM update after merging to not slow down CI for too long - I'd think that we could probably do so around .NET 10 GA release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
We will have to update the VMs for this, we can merge it and not update the VMs but there will be some additional pipeline time hit.
I guess fine, I'll make another task to update them again after this gets merged.