test: Test infrastructure cleanup (general) (#1723)

Signed-off-by: Dave Skender <[email protected]>
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: DaveSkender <[email protected]>

Author: Copilot

.coderabbit.yaml

@@ -22,8 +22,8 @@ reviews:
   estimate_code_review_effort: false
   poem: false
 
-  related_issues: false
-  related_prs: false
+  related_issues: true
+  related_prs: true
 
   suggested_labels: false
   auto_apply_labels: false

.devcontainer/devcontainer.json

@@ -21,8 +21,8 @@
     "ghcr.io/devcontainers/features/github-cli:1": {
       "version": "latest"
     },
-    "ghcr.io/devcontainers/features/node:1": {
-      "version": "24.10.0"
+    "ghcr.io/devcontainers-extra/features/angular-cli:2": {
+      "version": "latest"
     },
     "ghcr.io/devcontainers/features/ruby:1": {
       "version": "3.3"

.devcontainer/startup.sh

@@ -19,21 +19,10 @@ fi
 # Apply to current session
 eval "$TOOLS_PATH_LINE"
 
-# Verify Node.js and npm are available
-echo "🔍 Verifying Node.js environment..."
-node --version
-npm install --global npm@latest
-npm --version
-
 # Verify .NET is available
 echo "🔍 Verifying .NET environment..."
 dotnet --version
 
-# Restore global tools
-echo "🧰 Installing NPM-based tools..."
-npm install --global @angular/cli
-npm list --global
-
 echo "🧰 Installing .NET-based tools..."
 dotnet tool install --global dotnet-format
 dotnet tool install --global roslynator.dotnet.cli

.github/agents/streamhub-testing.agent.md

@@ -77,7 +77,7 @@ Every StreamHub QuoteObserver test MUST cover these scenarios:
 
 ```csharp
 [TestMethod]
-public void QuoteObserver()
+public void QuoteObserver_WithWarmupLateArrivalAndRemoval_MatchesSeriesExactly()
 {
     IQuoteProvider<IQuote> quotes = GetQuotesProvider();
 
@@ -215,7 +215,7 @@ public void Standard()
 
 ```csharp
 [TestMethod]
-public void QuoteObserver()
+public void QuoteObserver_WithWarmupLateArrivalAndRemoval_MatchesSeriesExactly()
 {
     // Warmup + stream + duplicates + Insert + Remove + parity check
     // (See canonical pattern above)
@@ -298,7 +298,7 @@ public void CustomToString()
 
 ### Interface methods - based on provider pattern
 
-- `QuoteObserver()` - If implementing ITestQuoteObserver
+- `QuoteObserver_WithWarmupLateArrivalAndRemoval_MatchesSeriesExactly()` - If implementing ITestQuoteObserver
 - `ChainObserver()` - If implementing ITestChainObserver
 - `ChainProvider()` - If implementing ITestChainProvider
 - `PairsObserver()` - If implementing ITestPairsObserver

.github/instructions/codacy.instructions.md

@@ -15,7 +15,7 @@ Configuration for AI behavior when interacting with Codacy's MCP Server
   - repository: Stock.Indicators
   - Avoid calling `git remote -v` unless really necessary
 
-## CRITICAL: After ANY successful `edit_file` or `reapply` operation
+## After ANY successful `edit_file` or `reapply` operation
 
 - For complex or significant file changes run the `codacy_cli_analyze` tool from Codacy's MCP Server for each file that was edited before finishing your turn, with:
   - `rootPath`: set to the workspace path
@@ -26,12 +26,10 @@ Configuration for AI behavior when interacting with Codacy's MCP Server
 
 ## When you tried to run the `codacy_cli_analyze` tool and the Codacy CLI is not installed
 
-- Check if the project has `@codacy/codacy-mcp` NPM package installed in `package.json` devDependencies
-- If the NPM package is installed but CLI is not available, recommend running `npm install` to ensure dependencies are installed
-- If the NPM package is not installed, ask the user 'Codacy CLI is not available. This project uses NPM packages for Codacy. Would you like me to add the @codacy/codacy-mcp package to devDependencies?'
-- If the user responds with "yes", run `npm install --save-dev @codacy/codacy-mcp` and then continue with the original task
-- If the user responds with "no", instruct the user that they can disable automatic analysis in the extension settings
-- Wait for the user to respond before proceeding with any other actions
+- Simply use `npx @codacy/codacy-mcp` to invoke the Codacy CLI directly
+- npx will automatically download and run the tool without requiring installation
+- Do not ask the user to install anything
+- Continue with the analysis using the npx command
 
 ## After every response
 
@@ -51,12 +49,11 @@ Configuration for AI behavior when interacting with Codacy's MCP Server
 ## CRITICAL: Dependencies and Security Checks
 
 - IMMEDIATELY after ANY of these actions:
-  - Running npm/yarn/pnpm install
-  - Adding dependencies to package.json
-  - Adding requirements to requirements.txt
+  - Adding dependencies to requirements.txt
   - Adding dependencies to pom.xml
   - Adding dependencies to build.gradle
-  - Any other package manager operations
+  - Adding dependencies to .csproj files
+  - Any other package manager operations (excluding npm/yarn/pnpm as this project does not use Node.js packages)
 - You MUST run the `codacy_cli_analyze` tool with:
   - `rootPath`: set to the workspace path
   - `tool`: set to "trivy"
@@ -65,10 +62,6 @@ Configuration for AI behavior when interacting with Codacy's MCP Server
   - Stop all other operations
   - Propose and apply fixes for the security issues
   - Only continue with the original task after security issues are resolved
-- EXAMPLE:
-  - After: npm install react-markdown
-  - Do: Run codacy_cli_analyze with trivy
-  - Before: Continuing with any other tasks
 
 ## General
 
@@ -78,7 +71,7 @@ Configuration for AI behavior when interacting with Codacy's MCP Server
 - Do not run `codacy_cli_analyze` looking for changes in duplicated code or code complexity metrics.
 - Complexity metrics are different from complexity issues. When trying to fix complexity in a repository or file, focus on solving the complexity issues and ignore the complexity metric.
 - Do not run `codacy_cli_analyze` looking for changes in code coverage.
-- The Codacy CLI is available through the `@codacy/codacy-mcp` NPM package installed in this project's devDependencies.
+- The Codacy CLI can be invoked via `npx @codacy/codacy-mcp` when needed.
 - When calling `codacy_cli_analyze`, only send provider, organization and repository if the project is a git repository.
 
 ## Whenever a call to a Codacy tool that uses `repository` or `organization` as a parameter returns a 404 error
@@ -89,4 +82,4 @@ Configuration for AI behavior when interacting with Codacy's MCP Server
 - After setup, immediately retry the action that failed (only retry once)
 
 ---
-Last updated: October 12, 2025
+Last updated: November 5, 2025

.github/instructions/indicator-stream.instructions.md

@@ -396,14 +396,14 @@ public class CorrelationHub : StreamHubTestBase, ITestPairsObserver
 
 #### ITestQuoteObserver interface
 
-The `ITestQuoteObserver` interface is required for all indicators that support direct quote provider observation. It replaces the need to override `QuoteObserver()` in the test class. Implement this interface and provide a `QuoteObserver()` method to test hub compatibility with quote providers. See `Ema.StreamHub.Tests.cs` for a reference implementation.
+The `ITestQuoteObserver` interface is required for all indicators that support direct quote provider observation. It replaces the need to override `QuoteObserver_WithWarmupLateArrivalAndRemoval_MatchesSeriesExactly()` in the test class. Implement this interface and provide a `QuoteObserver_WithWarmupLateArrivalAndRemoval_MatchesSeriesExactly()` method to test hub compatibility with quote providers. See `Ema.StreamHub.Tests.cs` for a reference implementation.
 
 **When to use:**
 
 - All indicators that can be observed directly from a quote provider (e.g., EMA, SMA, Renko, etc.)
 - Not required for dual-stream (pairs) indicators
 
-**Do not override `QuoteObserver()` in the test class; implement `ITestQuoteObserver` instead.**
+**Do not override `QuoteObserver_WithWarmupLateArrivalAndRemoval_MatchesSeriesExactly()` in the test class; implement `ITestQuoteObserver` instead.**
 
 ### Comprehensive rollback validation (required)
 
@@ -420,7 +420,7 @@ These scenarios replace the need for a separate rollback-specific interface.
 
 ### Provider history (Insert/Remove) testing
 
-Provider history mutations are required and are part of the “Comprehensive rollback validation” section above (see EMA hub tests for the canonical pattern). Use `ProviderHistoryTesting()` in `StreamHubTestBase` as needed for indicator-specific logic.
+Provider history mutations are required and are part of the “Comprehensive rollback validation” section above (see EMA hub tests for the canonical pattern). Use `AssertProviderHistoryIntegrity()` in `StreamHubTestBase` as needed for indicator-specific logic.
 
 ### Performance benchmarking
 

.github/instructions/source-code-completion.instructions.md

@@ -36,8 +36,8 @@ These instructions apply to all files in the `src/` and `tests/` folders and cov
 
 - Run `dotnet restore` (or the **Restore: .NET Packages** task).
 - Run `dotnet format` to auto-correct stylistic issues.
-- Run `npm run lint:md:fix` whenever documentation changed.
-- If tooling changed, delete `package-lock.json` and `node_modules/`, then run `npm install` to regenerate the lock file.
+- Run `npx markdownlint-cli2 --fix` (or the **Fix: Markdown files** task) whenever documentation changed.
+- If linting configuration changed, verify `npx markdownlint-cli2` still works correctly.
 
 ### Step 2 – Formatting and analyzer checks
 
@@ -79,10 +79,10 @@ These instructions apply to all files in the `src/` and `tests/` folders and cov
 
 ### Step 2 – Lint markdown documentation
 
-- Run `npm run lint:md:fix` to auto-correct basic issues.
-- Run `npm run lint:md` (or the **Lint: Markdown Files** task) and fix remaining warnings.
+- Run `npx markdownlint-cli2 --fix` (or the **Fix: Markdown files** task) to auto-correct basic issues.
+- Run `npx markdownlint-cli2` (or the **Lint: Markdown Files** task) and fix remaining warnings.
 
-> **Verification**: `npm run lint:md` exits with zero warnings.
+> **Verification**: `npx markdownlint-cli2` exits with zero warnings.
 
 ### Step 3 – Final verification: Perform a full clean sweep
 
@@ -92,7 +92,7 @@ Run this sequence and confirm each command completes successfully.
 dotnet format --verify-no-changes
 dotnet build "Stock.Indicators.sln" -v minimal --nologo
 dotnet test "Stock.Indicators.sln" --no-build --nologo
-npm run lint:md
+npx markdownlint-cli2
 ```
 
 If any command fails, fix the issue and restart this step from the top.
@@ -121,7 +121,7 @@ chmod +x codacy-analysis-cli
 Run the following sequence to detect hidden state issues.
 
 ```bash
-npm run clean
+bash tools/scripts/clean.sh
 dotnet restore
 dotnet build "Stock.Indicators.sln" -v minimal --nologo
 dotnet test "Stock.Indicators.sln" --no-build --nologo

.github/workflows/copilot-setup-steps.yml

@@ -32,14 +32,6 @@ jobs:
           bundler-cache: true
           working-directory: docs
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v6
-        with:
-          node-version: ">=24.10.0"
-          cache: "npm"
-          cache-dependency-path: package-lock.json
-        continue-on-error: true
-
       - name: Setup .NET SDK
         uses: actions/setup-dotnet@v5
         with:
@@ -68,7 +60,7 @@ jobs:
 
       - name: Restore packages
         run: |
-          dotnet restore && npm ci
+          dotnet restore
         continue-on-error: true
 
       - name: Build .NET Solution

.github/workflows/test-website-a11y.yml

@@ -56,7 +56,7 @@ jobs:
 
       - name: Test accessibility
         run: >
-          pa11y-ci
+          npx pa11y-ci
           --sitemap http://127.0.0.1:4000/sitemap.xml
           --config ./.pa11yci