Skip to content

Commit db3565e

Browse files
authored
Merge pull request #1 from DivineOmega/analysis-8mDnjb
Apply fixes from StyleCI
2 parents 6c0dc25 + 73f7ca5 commit db3565e

File tree

3 files changed

+66
-67
lines changed

3 files changed

+66
-67
lines changed

src/Pluralizer.php

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace DivineOmega\WordInfo;
34

45
use Doctrine\Common\Inflector\Inflector;
@@ -14,7 +15,7 @@ class Pluralizer
1415
'education',
1516
'love',
1617
'pokemon',
17-
'mathematics'
18+
'mathematics',
1819
];
1920

2021
private $word;
@@ -30,8 +31,8 @@ public function pluralize()
3031
return new Word($this->word);
3132
}
3233

33-
foreach($this->irregular as $singular => $plural) {
34-
if ($singular==$this->word) {
34+
foreach ($this->irregular as $singular => $plural) {
35+
if ($singular == $this->word) {
3536
return new Word($plural);
3637
}
3738
}
@@ -47,11 +48,11 @@ public function singularize()
4748
return new Word($this->word);
4849
}
4950

50-
foreach($this->irregular as $singular => $plural) {
51-
if ($plural==$this->word) {
51+
foreach ($this->irregular as $singular => $plural) {
52+
if ($plural == $this->word) {
5253
return new Word($singular);
5354
}
54-
}
55+
}
5556

5657
$singular = Inflector::singularize((string) $this->word);
5758

@@ -60,6 +61,6 @@ public function singularize()
6061

6162
private function isUncountable()
6263
{
63-
return (in_array($this->word, $this->uncountable));
64+
return in_array($this->word, $this->uncountable);
6465
}
65-
}
66+
}

src/Word.php

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<?php
2+
23
namespace DivineOmega\WordInfo;
34

4-
use rapidweb\RWFileCache\RWFileCache;
5-
use Snipe\BanBuilder\CensorWords;
65
use DaveChild\TextStatistics\Syllables;
6+
use rapidweb\RWFileCache\RWFileCache;
77

8-
class Word {
9-
8+
class Word
9+
{
1010
private $word;
1111
private $cache;
1212

@@ -23,7 +23,7 @@ public function __toString()
2323

2424
private function setupCache()
2525
{
26-
$this->cache = new RWFileCache;
26+
$this->cache = new RWFileCache();
2727
$this->cache->changeConfig(['cacheDirectory' => '/tmp/php-word-info-cache/']);
2828
}
2929

@@ -46,22 +46,22 @@ public function rhymes($halfRhymes = false)
4646

4747
$rhymes = [];
4848

49-
foreach($responseItems as $responseItem) {
49+
foreach ($responseItems as $responseItem) {
5050
if ($halfRhymes) {
5151
if ($responseItem->score < 300) {
52-
$rhymes[] = new Word($responseItem->word);
52+
$rhymes[] = new self($responseItem->word);
5353
}
5454
} else {
55-
if($responseItem->score == 300) {
56-
$rhymes[] = new Word($responseItem->word);
57-
}
55+
if ($responseItem->score == 300) {
56+
$rhymes[] = new self($responseItem->word);
57+
}
5858
}
5959
}
6060

6161
sort($rhymes);
6262

6363
$this->cache->set($cacheKey, $rhymes);
64-
64+
6565
return $rhymes;
6666
}
6767

@@ -105,11 +105,11 @@ public function portmanteaus()
105105

106106
$portmanteaus = [];
107107

108-
foreach($responseItems as $responseItem) {
109-
$responseItemPortmanteaus = array_map(function($portmanteauString) {
108+
foreach ($responseItems as $responseItem) {
109+
$responseItemPortmanteaus = array_map(function ($portmanteauString) {
110110
return new Word($portmanteauString);
111111
}, explode(',', $responseItem->combined));
112-
112+
113113
$portmanteaus = array_merge($portmanteaus, $responseItemPortmanteaus);
114114
}
115115

@@ -119,5 +119,4 @@ public function portmanteaus()
119119

120120
return $portmanteaus;
121121
}
122-
123-
}
122+
}

tests/Unit/WordTest.php

Lines changed: 42 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
<?php
22

3-
use PHPUnit\Framework\TestCase;
43
use DivineOmega\WordInfo\Word;
4+
use PHPUnit\Framework\TestCase;
55

66
final class WordTest extends TestCase
77
{
88
public function testRhymes()
99
{
1010
$rhymes = (new Word('cat'))->rhymes();
1111

12-
$expected = ['aristocrat', 'at', 'bat', 'caveat', 'chat', 'democrat', 'diplomat',
13-
'fat', 'flat', 'habitat', 'hat', 'mat', 'pat', 'rat', 'sat', 'spat',
14-
'stat', 'tat', 'that', 'thermostat', 'vat'];
12+
$expected = ['aristocrat', 'at', 'bat', 'caveat', 'chat', 'democrat', 'diplomat',
13+
'fat', 'flat', 'habitat', 'hat', 'mat', 'pat', 'rat', 'sat', 'spat',
14+
'stat', 'tat', 'that', 'thermostat', 'vat', ];
1515

1616
$this->assertEquals($expected, $rhymes);
1717
}
@@ -20,9 +20,9 @@ public function testHalfRhymes()
2020
{
2121
$rhymes = (new Word('violet'))->halfRhymes();
2222

23-
$expected = ['cyclist', 'finalist', 'hybridised', 'iodised', 'ionised', 'lionised',
24-
'motorcyclist', 'nihilist', 'piloted', 'pirated', 'playacted', 'revivalist',
25-
'rioted', 'scientist', 'semifinalist', 'survivalist'];
23+
$expected = ['cyclist', 'finalist', 'hybridised', 'iodised', 'ionised', 'lionised',
24+
'motorcyclist', 'nihilist', 'piloted', 'pirated', 'playacted', 'revivalist',
25+
'rioted', 'scientist', 'semifinalist', 'survivalist', ];
2626

2727
$this->assertEquals($expected, $rhymes);
2828
}
@@ -95,20 +95,20 @@ public function testPortmanteaus1()
9595
{
9696
$portmanteaus = (new Word('computer'))->portmanteaus();
9797

98-
$expected = ['computarena', 'computarise', 'computarisen', 'computarises', 'computarising', 'computaristocratic', 'computaroma',
99-
'computarose', 'computaround', 'computarousal', 'computarouse', 'computaroused', 'computarousing', 'computarrange',
98+
$expected = ['computarena', 'computarise', 'computarisen', 'computarises', 'computarising', 'computaristocratic', 'computaroma',
99+
'computarose', 'computaround', 'computarousal', 'computarouse', 'computaroused', 'computarousing', 'computarrange',
100100
'computarranged', 'computarrangement', 'computarrangements', 'computarranging', 'computarray', 'computarrears', 'computarrest',
101-
'computarrested', 'computarresting', 'computarrests', 'computarrhythmias', 'computarrival', 'computarrivals', 'computarrive',
102-
'computarrived', 'computarrives', 'computarriving', 'computerena', 'computeriginal', 'computeriginality', 'computeriginally',
103-
'computeriginals', 'computeriginate', 'computeriginated', 'computeriginates', 'computeriginating', 'computerine', 'computerise',
104-
'computerisen', 'computerises', 'computerising', 'computeristocratic', 'computermination', 'computeroma', 'computerose',
105-
'computeround', 'computerousal', 'computerouse', 'computeroused', 'computerousing', 'computerrain', 'computerrestrial',
106-
'computerrific', 'computerrrange', 'computerrranged', 'computerrrangement', 'computerrrangements', 'computerrranging',
107-
'computerrray', 'computerrrears', 'computerrrest', 'computerrrested', 'computerrresting', 'computerrrests', 'computerrrhythmias',
108-
'computerrrival', 'computerrrivals', 'computerrrive', 'computerrrived', 'computerrrives', 'computerrriving', 'computerus',
109-
'computeryrannical', 'computoriginal', 'computoriginality', 'computoriginally', 'computoriginals', 'computoriginate',
110-
'computoriginated', 'computoriginates', 'computoriginating', 'computyrannical', 'incomputer', 'outcomputer', 'silicaomputer',
111-
'silicomputer', 'welcomputer'];
101+
'computarrested', 'computarresting', 'computarrests', 'computarrhythmias', 'computarrival', 'computarrivals', 'computarrive',
102+
'computarrived', 'computarrives', 'computarriving', 'computerena', 'computeriginal', 'computeriginality', 'computeriginally',
103+
'computeriginals', 'computeriginate', 'computeriginated', 'computeriginates', 'computeriginating', 'computerine', 'computerise',
104+
'computerisen', 'computerises', 'computerising', 'computeristocratic', 'computermination', 'computeroma', 'computerose',
105+
'computeround', 'computerousal', 'computerouse', 'computeroused', 'computerousing', 'computerrain', 'computerrestrial',
106+
'computerrific', 'computerrrange', 'computerrranged', 'computerrrangement', 'computerrrangements', 'computerrranging',
107+
'computerrray', 'computerrrears', 'computerrrest', 'computerrrested', 'computerrresting', 'computerrrests', 'computerrrhythmias',
108+
'computerrrival', 'computerrrivals', 'computerrrive', 'computerrrived', 'computerrrives', 'computerrriving', 'computerus',
109+
'computeryrannical', 'computoriginal', 'computoriginality', 'computoriginally', 'computoriginals', 'computoriginate',
110+
'computoriginated', 'computoriginates', 'computoriginating', 'computyrannical', 'incomputer', 'outcomputer', 'silicaomputer',
111+
'silicomputer', 'welcomputer', ];
112112

113113
$this->assertEquals($expected, $portmanteaus);
114114
}
@@ -117,42 +117,42 @@ public function testPortmanteaus2()
117117
{
118118
$portmanteaus = (new Word('cheese'))->portmanteaus();
119119

120-
$expected = ['chease', 'cheased', 'cheasel', 'cheasement', 'cheasements', 'cheases', 'cheasier', 'cheasiest', 'cheasily', 'cheasing',
121-
'cheasy', 'cheasygoing', 'chies', 'chiheese', 'chiis', 'chization', 'chys'];
120+
$expected = ['chease', 'cheased', 'cheasel', 'cheasement', 'cheasements', 'cheases', 'cheasier', 'cheasiest', 'cheasily', 'cheasing',
121+
'cheasy', 'cheasygoing', 'chies', 'chiheese', 'chiis', 'chization', 'chys', ];
122122

123123
$this->assertEquals($expected, $portmanteaus);
124124
}
125125

126126
private function getSingularToPluralData()
127127
{
128128
return [
129-
'cat' => 'cats',
130-
'mitten' => 'mittens',
131-
'sausage' => 'sausages',
132-
'child' => 'children',
133-
'goose' => 'geese',
134-
'person' => 'people',
135-
'woman' => 'women',
136-
'man' => 'men',
137-
'audio' => 'audio',
138-
'education' => 'education',
139-
'rice' => 'rice',
140-
'love' => 'love',
141-
'pokemon' => 'pokemon',
142-
'sheep' => 'sheep',
143-
'sex' => 'sexes',
144-
'mouse' => 'mice',
129+
'cat' => 'cats',
130+
'mitten' => 'mittens',
131+
'sausage' => 'sausages',
132+
'child' => 'children',
133+
'goose' => 'geese',
134+
'person' => 'people',
135+
'woman' => 'women',
136+
'man' => 'men',
137+
'audio' => 'audio',
138+
'education' => 'education',
139+
'rice' => 'rice',
140+
'love' => 'love',
141+
'pokemon' => 'pokemon',
142+
'sheep' => 'sheep',
143+
'sex' => 'sexes',
144+
'mouse' => 'mice',
145145
'mathematics' => 'mathematics',
146146
'information' => 'information',
147-
'tooth' => 'teeth'
147+
'tooth' => 'teeth',
148148
];
149149
}
150150

151151
public function testPluralise()
152152
{
153153
$data = $this->getSingularToPluralData();
154154

155-
foreach($data as $singular => $plural) {
155+
foreach ($data as $singular => $plural) {
156156
$word = new Word($singular);
157157
$this->assertEquals($plural, $word->plural());
158158
}
@@ -162,10 +162,9 @@ public function testSingularise()
162162
{
163163
$data = $this->getSingularToPluralData();
164164

165-
foreach($data as $singular => $plural) {
165+
foreach ($data as $singular => $plural) {
166166
$word = new Word($plural);
167167
$this->assertEquals($singular, $word->singular());
168168
}
169169
}
170-
171-
}
170+
}

0 commit comments

Comments
 (0)