Skip to content

Requests Warning - Conditional Render? #2971

@HPaulson

Description

@HPaulson

What problem will this feature address?

On the "Requests" tab, a warning about reloading traefik after enable is displayed regardless of how long request monitoring has been enabled, or if the config has been reloaded:

Image

<AlertBlock type="warning">
When you activate, you need to reload traefik to apply the
changes, you can reload traefik in{" "}
<Link
href="/dashboard/settings/server"
className="text-primary"
>
Settings
</Link>
</AlertBlock>

This isn’t a bug per se, but it can be a bit annoying as it shows unnecessarily in the UI.

Describe the solution you'd like

It would be nice if this warning could be conditionally rendered. If there are any logs to be displayed, it can be safely assumed that traefik was reloaded successfully, and this warning need not be shown.

Describe alternatives you've considered

Alternatively, the warning can have a dismiss 'x' that, when clicked, will make the warning disappear. This state can be saved in the db or local storage. If request logs are later deactivated, this state is reset so that the warning will re-appear on reenable.

Additional context

No response

Will you send a PR to implement it?

Maybe, need help. Happy to submit a first PR if this feature is desirable, but would like guidance on the preferred implementation approach.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions