Skip to content

feat: Add ability to stop running schedules (#2853) #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: Add ability to stop running schedules (#2853) #2960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4743caa
feat: Add ability to stop running schedules (#2853)
Harikrishnan1367709 Nov 5, 2025
10c355e
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
191 changes: 139 additions & 52 deletions apps/dokploy/components/dashboard/application/schedules/show-schedules.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
Clock,
Loader2,
Play,
Square,
Terminal,
Trash2,
} from "lucide-react";
Expand Down Expand Up @@ -34,43 +35,34 @@ interface Props {
}

export const ShowSchedules = ({ id, scheduleType = "application" }: Props) => {
const [runningSchedules, setRunningSchedules] = useState<Set<string>>(
new Set(),
const [stoppingScheduleId, setStoppingScheduleId] = useState<string | null>(
null,
);
const {
data: schedules,
isLoading: isLoadingSchedules,
refetch: refetchSchedules,
} = api.schedule.list.useQuery(
{
id: id || "",
scheduleType,
},
{
enabled: !!id,
},
const [runningScheduleId, setRunningScheduleId] = useState<string | null>(
null,
);

const utils = api.useUtils();

const { data: schedules, isLoading: isLoadingSchedules } =
api.schedule.list.useQuery(
{
id: id || "",
scheduleType,
},
{
enabled: !!id,
refetchInterval: 3000, // Poll every 3 seconds to check for running status
refetchOnWindowFocus: false,
},
);

const { mutateAsync: deleteSchedule, isLoading: isDeleting } =
api.schedule.delete.useMutation();

const { mutateAsync: runManually } = api.schedule.runManually.useMutation();

const handleRunManually = async (scheduleId: string) => {
setRunningSchedules((prev) => new Set(prev).add(scheduleId));
try {
await runManually({ scheduleId });
toast.success("Schedule run successfully");
await refetchSchedules();
} catch {
toast.error("Error running schedule");
} finally {
setRunningSchedules((prev) => {
const newSet = new Set(prev);
newSet.delete(scheduleId);
return newSet;
});
}
};
const { mutateAsync: stopSchedule } = api.schedule.stop.useMutation();

return (
<Card className="border px-6 shadow-none bg-transparent h-full min-h-[50vh]">
Expand Down Expand Up @@ -104,6 +96,13 @@ export const ShowSchedules = ({ id, scheduleType = "application" }: Props) => {
schedule.serverId ||
schedule.application?.serverId ||
schedule.compose?.serverId;

// Check if schedule has a running deployment
const runningDeployment = schedule.deployments?.find(
(deployment) => deployment.status === "running",
);
const isRunning = !!runningDeployment;

return (
<div
key={schedule.scheduleId}
Expand All @@ -124,6 +123,14 @@ export const ShowSchedules = ({ id, scheduleType = "application" }: Props) => {
>
{schedule.enabled ? "Enabled" : "Disabled"}
</Badge>
{isRunning && (
<Badge
variant="default"
className="text-[10px] px-1 py-0 bg-green-500 hover:bg-green-600"
>
Running
</Badge>
)}
</div>
<div className="flex items-center gap-2 text-sm text-muted-foreground flex-wrap">
<Badge
Expand Down Expand Up @@ -167,28 +174,108 @@ export const ShowSchedules = ({ id, scheduleType = "application" }: Props) => {
<ClipboardList className="size-4 transition-colors" />
</Button>
</ShowDeploymentsModal>
<TooltipProvider delayDuration={0}>
<Tooltip>
<TooltipTrigger asChild>
<Button
type="button"
variant="ghost"
size="icon"
disabled={runningSchedules.has(schedule.scheduleId)}
onClick={() =>
handleRunManually(schedule.scheduleId)
}
>
{runningSchedules.has(schedule.scheduleId) ? (
<Loader2 className="size-4 animate-spin" />
) : (
<Play className="size-4 transition-colors" />
)}
</Button>
</TooltipTrigger>
<TooltipContent>Run Manual Schedule</TooltipContent>
</Tooltip>
</TooltipProvider>

{isRunning || stoppingScheduleId === schedule.scheduleId ? (
<TooltipProvider delayDuration={0}>
<Tooltip>
<TooltipTrigger asChild>
<DialogAction
title="Stop Running Schedule"
description="Are you sure you want to stop this running schedule? The current execution will be interrupted."
type="default"
onClick={async () => {
const scheduleId = schedule.scheduleId;
setStoppingScheduleId(scheduleId);
try {
await stopSchedule({
scheduleId,
});
// Clear loading state immediately - this triggers a re-render
setStoppingScheduleId(null);
toast.success(
"Schedule stopped successfully",
);
// Invalidate in background without awaiting
utils.schedule.list
.invalidate({
id,
scheduleType,
})
.catch(() => {
// Silently handle background refetch errors
});
} catch (error) {
// Clear loading on error too
setStoppingScheduleId(null);
toast.error(
error instanceof Error
? error.message
: "Error stopping schedule",
);
}
}}
>
<Button
type="button"
variant="destructive"
size="icon"
isLoading={
stoppingScheduleId === schedule.scheduleId
}
>
<Square className="size-4" />
</Button>
</DialogAction>
</TooltipTrigger>
<TooltipContent>Stop Running Schedule</TooltipContent>
</Tooltip>
</TooltipProvider>
) : (
<TooltipProvider delayDuration={0}>
<Tooltip>
<TooltipTrigger asChild>
<Button
type="button"
variant="ghost"
size="icon"
isLoading={
runningScheduleId === schedule.scheduleId
}
onClick={async () => {
setRunningScheduleId(schedule.scheduleId);
try {
await runManually({
scheduleId: schedule.scheduleId,
});
// Clear loading immediately
setRunningScheduleId(null);
toast.success("Schedule run successfully");
// Invalidate in background without awaiting
utils.schedule.list
.invalidate({
id,
scheduleType,
})
.catch(() => {
// Silently handle background refetch errors
});
} catch (error) {
setRunningScheduleId(null);
toast.error(
error instanceof Error
? error.message
: "Error running schedule",
);
}
}}
>
<Play className="size-4 transition-colors" />
</Button>
</TooltipTrigger>
<TooltipContent>Run Manual Schedule</TooltipContent>
</Tooltip>
</TooltipProvider>
)}
<HandleSchedules
scheduleId={schedule.scheduleId}
id={id}
Expand Down
75 changes: 74 additions & 1 deletion apps/dokploy/server/api/routers/schedule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ import {
schedules,
updateScheduleSchema,
} from "@dokploy/server/db/schema/schedule";
import {
execAsync,
execAsyncRemote,
updateDeploymentStatus,
} from "@dokploy/server";
import { runCommand } from "@dokploy/server/index";
import {
createSchedule,
Expand All @@ -14,7 +19,7 @@ import {
updateSchedule,
} from "@dokploy/server/services/schedule";
import { TRPCError } from "@trpc/server";
import { desc, eq } from "drizzle-orm";
import { and, desc, eq } from "drizzle-orm";
import { z } from "zod";
import { removeJob, schedule } from "@/server/utils/backup";
import { createTRPCRouter, protectedProcedure } from "../trpc";
Expand Down Expand Up @@ -138,4 +143,72 @@ export const scheduleRouter = createTRPCRouter({
});
}
}),

stop: protectedProcedure
.input(z.object({ scheduleId: z.string().min(1) }))
.mutation(async ({ input }) => {
// Find the running deployment for this schedule
const runningDeployment = await db.query.deployments.findFirst({
where: and(
eq(deployments.scheduleId, input.scheduleId),
eq(deployments.status, "running"),
),
with: {
schedule: {
with: {
application: true,
compose: true,
server: true,
},
},
},
orderBy: [desc(deployments.createdAt)],
});

if (!runningDeployment) {
throw new TRPCError({
code: "NOT_FOUND",
message: "No running schedule found",
});
}

if (!runningDeployment.pid) {
// If no PID, just mark as cancelled
await updateDeploymentStatus(
runningDeployment.deploymentId,
"cancelled",
);
return {
success: true,
message: "Schedule stopped successfully",
};
}

// Determine server ID for remote execution
const serverId =
runningDeployment.schedule?.serverId ||
runningDeployment.schedule?.application?.serverId ||
runningDeployment.schedule?.compose?.serverId;

// Kill the process
const command = `kill -9 ${runningDeployment.pid}`;
try {
if (serverId) {
await execAsyncRemote(serverId, command);
} else {
await execAsync(command);
}
} catch (error) {
// If kill fails, still mark as cancelled
console.error("Error killing process:", error);
}

// Update deployment status to cancelled
await updateDeploymentStatus(runningDeployment.deploymentId, "cancelled");

return {
success: true,
message: "Schedule stopped successfully",
};
}),
});