Skip to content

Conversation

@hregis
Copy link
Contributor

@hregis hregis commented Oct 31, 2025

No description provided.

@hregis hregis requested a review from eldy October 31, 2025 11:34
@hregis hregis changed the title NEW add possibility to not synchronize thirdparty <--> member NEW add possibility not to synchronize thirdparty <--> member Oct 31, 2025
@hregis hregis changed the title NEW add possibility not to synchronize thirdparty <--> member NEW add the option to not synchronize thirdparty <--> member Oct 31, 2025
@hregis
Copy link
Contributor Author

hregis commented Oct 31, 2025

@eldy phan and php-stan errors already fixed here : #36026

@hregis hregis force-pushed the new_dev_add_constant_thirdparty_member branch from 4a65230 to 6456782 Compare November 2, 2025 11:13
@hregis hregis requested a review from eldy November 2, 2025 11:15
@eldy eldy merged commit b6c27f8 into Dolibarr:develop Nov 2, 2025
5 checks passed
@iLLixM
Copy link
Contributor

iLLixM commented Nov 8, 2025

@hregis @eldy
Thank you very much for this special functional enhancement. I've noticed in various places that the mix of English and French in Dolibarr development is always a challenge. In this particular PR, I find this mix almost bizarre. The new system parameters are: MEMBER_NO_SYNC_LINKED_THIRDPARTY and SOCIETE_NO_SYNC_LINKED_MEMBER

Especially in the second case, the mix of the French "SOCIETE" and the English "MEMBER" is incomprehensible to me. Regarding the first parameter, I would have expected the following: THIRDPARTY_NO_SYNC_LINKED_MEMBER

According to the wiki, new parameters are usually introduced exclusively in English.
https://wiki.dolibarr.org/index.php/Setup_Other#Third_Parties_Module
Best regards

@eldy
Copy link
Member

eldy commented Nov 8, 2025

@hregis @eldy
Thank you very much for this special functional enhancement. I've noticed in various places that the mix of English and French in Dolibarr development is always a challenge. In this particular PR, I find this mix almost bizarre. The new system parameters are: MEMBER_NO_SYNC_LINKED_THIRDPARTY and SOCIETE_NO_SYNC_LINKED_MEMBER

Especially in the second case, the mix of the French "SOCIETE" and the English "MEMBER" is incomprehensible to me. Regarding the first parameter, I would have expected the following: THIRDPARTY_NO_SYNC_LINKED_MEMBER

According to the wiki, new parameters are usually introduced exclusively in English.
https://wiki.dolibarr.org/index.php/Setup_Other#Third_Parties_Module
Best regards

The reason is that the begin of a new parameter must follow the technical name of the module he is related to.
Currently it is SOCIETE. Renaming module technical key is not yet possible, we need to progress on other tasks first.

@iLLixM
Copy link
Contributor

iLLixM commented Nov 9, 2025

The reason is that the begin of a new parameter must follow the technical name of the module he is related to. Currently it is SOCIETE. Renaming module technical key is not yet possible, we need to progress on other tasks first.

Thank you for your reply @eldy .
Unfortunately, this statement, considering the naming of the system parameter MEMBER_NO_SYNC_LINKED_THIRDPARTY and many other parameters on the page https://wiki.dolibarr.org/index.php/Setup_Other, is causing even more confusion.

If the name of the affected module is decisive for the naming of system parameters, then many parameters recently added to the source code must have been named differently.
Especially with the Member or rather the Adherent module, there's a lot of confusion between the two terms.

Is it named the Member or the Adherent module?
Where is the definitive source for clearly identifying a module's title?
Can I see the title of a module in the name of the module folder in htdocs, or is that defined elsewhere?

Sorry for all the questions. I just want to know the correct procedure for any furture code additions.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants