fix: Do not check http method by default

Author: eduardbosch

dispatcher/src/main/kotlin/pl/droidsonroids/testing/mockwebserver/condition/HTTPMethod.kt

@@ -1,6 +1,7 @@
 package pl.droidsonroids.testing.mockwebserver.condition
 
 enum class HTTPMethod {
+    ANY,
     GET,
     HEAD,
     POST,

dispatcher/src/main/kotlin/pl/droidsonroids/testing/mockwebserver/condition/HttpUrlCondition.kt

@@ -9,10 +9,10 @@ import okhttp3.mockwebserver.RecordedRequest
  * Requests without <code>requestUrl</code>s are excluded from matching.
  */
 abstract class HttpUrlCondition : Condition {
-    internal open val httpMethod: HTTPMethod = HTTPMethod.GET
+    internal open val httpMethod: HTTPMethod = HTTPMethod.ANY
 
     override fun isRequestMatching(request: RecordedRequest): Boolean {
-        if (request.method != httpMethod.name) {
+        if (httpMethod != HTTPMethod.ANY && request.method != httpMethod.name) {
             return false
         }
 

dispatcher/src/main/kotlin/pl/droidsonroids/testing/mockwebserver/condition/PathQueryConditionFactory.kt

@@ -21,7 +21,7 @@ class PathQueryConditionFactory constructor(private val pathPrefix: String = "")
         pathSuffix: String,
         queryParameterName: String,
         queryParameterValue: String? = null,
-        httpMethod: HTTPMethod = HTTPMethod.GET,
+        httpMethod: HTTPMethod = HTTPMethod.ANY,
     ) =
         PathQueryCondition(
             pathPrefix + pathSuffix,
@@ -38,7 +38,7 @@ class PathQueryConditionFactory constructor(private val pathPrefix: String = "")
      */
     fun withPathSuffix(
         pathSuffix: String,
-        httpMethod: HTTPMethod = HTTPMethod.GET,
+        httpMethod: HTTPMethod = HTTPMethod.ANY,
     ) =
         PathQueryCondition(
             pathPrefix + pathSuffix,
@@ -52,7 +52,7 @@ class PathQueryConditionFactory constructor(private val pathPrefix: String = "")
      */
     fun withPath(
         path: String,
-        httpMethod: HTTPMethod = HTTPMethod.GET,
+        httpMethod: HTTPMethod = HTTPMethod.ANY,
     ) =
         PathQueryCondition(
             path,
@@ -76,7 +76,7 @@ class PathQueryConditionFactory constructor(private val pathPrefix: String = "")
         pathInfix: String,
         queryParameterName: String,
         queryParameterValue: String,
-        httpMethod: HTTPMethod = HTTPMethod.GET,
+        httpMethod: HTTPMethod = HTTPMethod.ANY,
     ) =
         withPathSuffixAndQueryParameter(
             pathInfix,

dispatcher/src/test/kotlin/pl/droidsonroids/testing/mockwebserver/condition/HttpUrlConditionTest.kt

@@ -64,4 +64,25 @@ class HttpUrlConditionTest {
 
         assertThat(matchAllUrlCondition.isRequestMatching(request)).isTrue
     }
+
+    @Test
+    fun `request with URL with any request method should match any request method`() {
+        HTTPMethod.values()
+            .filter { it != HTTPMethod.ANY }
+            .forEach { httpMethod->
+                val matchAllUrlCondition = object : HttpUrlCondition() {
+                    override val httpMethod: HTTPMethod
+                        get() = HTTPMethod.ANY
+
+                    override fun isUrlMatching(url: HttpUrl) = true
+                    override fun compareTo(other: Condition) = 0
+                }
+                val request =
+                    RecordedRequest("${httpMethod.name} /some/path HTTP/1.1", Headers.headersOf(), emptyList(), 0, Buffer(), 0, socket)
+
+                assertThat(matchAllUrlCondition.isRequestMatching(request))
+                    .withFailMessage { "${httpMethod.name} does not match condition" }
+                    .isTrue
+            }
+    }
 }