Fixes to pass my integration tests #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove extra quotes for `set_target_properties` which were problematic when buildoptions already got quotes.
… library path is correct.
- Fix indentation. - Fix empty test for `cfg.sanitize`.
…NFIG:Release-x86>` produces errors)
Margen67
reviewed
Jul 14, 2025
| } | ||
|
|
||
| local default_toolset_map = { | ||
| ["windows"] = "msc-v142", -- Visual Studio 2019 |
There was a problem hiding this comment.
Suggested change
| ["windows"] = "msc-v142", -- Visual Studio 2019 | |
| ["windows"] = "msc-v143", -- Visual Studio 2022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for:
Fix link to sibbling projects
Tested with https://github.com/Jarod42/premake-sample-projects